You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "furqaankhan (via GitHub)" <gi...@apache.org> on 2023/07/25 06:48:04 UTC

[GitHub] [sedona] furqaankhan opened a new pull request, #918: Second10docs

furqaankhan opened a new pull request, #918:
URL: https://github.com/apache/sedona/pull/918

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - No, this is a documentation update. The PR name follows the format `[DOCS] my subject`.
   
   
   ## What changes were proposed in this PR?
   
   The following functions' docs were edited both in Spark and Flink:
   
   ST_Azimuth, ST_Boundary, ST_Buffer, ST_Centroid, ST_ConcaveHull, ST_ConvexHull, ST_CoordDim, ST_Degrees, ST_Dimension, ST_Distance, ST_DistanceSphere, and ST_DistanceSpheroid
   
   ## How was this patch tested?
   
   On my local Ubuntu VM.
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I have updated the documentation update.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sedona] furqaankhan commented on a diff in pull request #918: [DOCS] Add example outputs to all Sedona functions - 2

Posted by "furqaankhan (via GitHub)" <gi...@apache.org>.
furqaankhan commented on code in PR #918:
URL: https://github.com/apache/sedona/pull/918#discussion_r1273862803


##########
docs/api/flink/Function.md:
##########
@@ -576,14 +596,14 @@ Since: `v1.4.0`
 Example:
 
 ```sql
-SELECT ST_ConcaveHull(polygondf.countyshape, pctConvex)`
-FROM polygondf
+SELECT ST_ConcaveHull(ST_GeomFromWTK('POLYGON((175 150, 20 40, 50 60, 125 100, 175 150))'), 1)

Review Comment:
   Fixing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sedona] jiayuasu commented on a diff in pull request #918: [DOCS] Add example outputs to all Sedona functions - 2

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #918:
URL: https://github.com/apache/sedona/pull/918#discussion_r1273854644


##########
docs/api/flink/Function.md:
##########
@@ -576,14 +596,14 @@ Since: `v1.4.0`
 Example:
 
 ```sql
-SELECT ST_ConcaveHull(polygondf.countyshape, pctConvex)`
-FROM polygondf
+SELECT ST_ConcaveHull(ST_GeomFromWTK('POLYGON((175 150, 20 40, 50 60, 125 100, 175 150))'), 1)

Review Comment:
   Why is this `WTK` instead of `WKT`? This occurred a few times in your PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sedona] jiayuasu merged pull request #918: [DOCS] Add example outputs to all Sedona functions - 2

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #918:
URL: https://github.com/apache/sedona/pull/918


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org