You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/08 01:04:54 UTC
[GitHub] [pulsar] hdiode-florian opened a new pull request, #16459: [fix][python client] Fix `type` to `str` conversion in exceptions thrown in `definition.py`
hdiode-florian opened a new pull request, #16459:
URL: https://github.com/apache/pulsar/pull/16459
Fixes #16457
### Motivation
In several places https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/python/pulsar/schema/definition.py uses incorrect type (name) to string conversions when exceptions are raised (see for #16443 for examples). This might not be obvious at first sight because the call trace actually contains that somewhat resembles the intended exception message. The error occurs when the messages are created by concatenating "strings" with the + operator. This fails when one operand is a `type`.
### Modifications
Instead of attempting to directly convert a `type` to a `str`, I replaced all occurrences with `some_type.__name__`.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun closed pull request #16459: [fix][python client] Fix `type` to `str` conversion in exceptions thrown in `definition.py`
Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #16459: [fix][python client] Fix `type` to `str` conversion in exceptions thrown in `definition.py`
URL: https://github.com/apache/pulsar/pull/16459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16459: [fix][python client] Fix `type` to `str` conversion in exceptions thrown in `definition.py`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16459:
URL: https://github.com/apache/pulsar/pull/16459#issuecomment-1178424176
@hdiode-florian Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hdiode-florian commented on pull request #16459: [fix][python client] Fix `type` to `str` conversion in exceptions thrown in `definition.py`
Posted by GitBox <gi...@apache.org>.
hdiode-florian commented on PR #16459:
URL: https://github.com/apache/pulsar/pull/16459#issuecomment-1178442525
Do not merge. It seems there are cases where `types` are in fact `str`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16459: [fix][python client] Fix `type` to `str` conversion in exceptions thrown in `definition.py`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16459:
URL: https://github.com/apache/pulsar/pull/16459#issuecomment-1178422427
@hdiode-florian Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16459: [fix][python client] Fix `type` to `str` conversion in exceptions thrown in `definition.py`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16459:
URL: https://github.com/apache/pulsar/pull/16459#issuecomment-1207316066
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16459: [fix][python client] Fix `type` to `str` conversion in exceptions thrown in `definition.py`
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16459:
URL: https://github.com/apache/pulsar/pull/16459#issuecomment-1309641947
The development of the Python client has been permanently moved to https://github.com/apache/pulsar-client-python. You can open a pull request there instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org