You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/07 15:59:34 UTC
[GitHub] [cloudstack-primate] rhtyd opened a new issue #510: Build and packaging improvements
rhtyd opened a new issue #510:
URL: https://github.com/apache/cloudstack-primate/issues/510
Hi @utchoang can you explore the following after your current issue, thanks.
1. Explore and optimise build specifically around this npm build warning: (i.e. can we make bundle smaller to load application faster)
```
asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
js/app.93807bba.js (2.55 MiB)
css/chunk-vendors.ed28034b.css (512 KiB)
js/chunk-vendors.27bdb886.js (2.55 MiB)
color.less (266 KiB)
```
2. For both rpm and deb packaging (see https://github.com/apache/cloudstack-primate/tree/master/packaging and packaging.sh) can we ensure that on upgrade it won't overwrite the config.js file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #510:
URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658586035
@rhtyd Also can I use `core/lazy_use` instead of `core/use` in main.js? Because to avoid arising unused components.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #510: Build and packaging improvements
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #510:
URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-668474081
Have a PR, closing this to track on PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #510:
URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658585116
Currently, I have only found a few issues:
1. In node_modules, we use package `@antv/g2`, this package is used in the chart.
=> Ignore package `@antv/g2` because I think Primate doesn't seem to use the chart.
2. Ant design icons are imported entirely including icons not used in Primate
=> Only import component icons to use in Primate. Refer: https://stackoverflow.com/questions/48721290/ant-design-huge-imports
3. In src/locales, JSON files are being imported directly, so its size is very large (> 2 MB)
=> There is still no better way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #510:
URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-660823292
@rhtyd What do you think about my comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #510: Build and packaging improvements
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #510:
URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658585116
@rhtyd cc @svenvogel
Currently, I have only found a few issues:
1. In node_modules, we use package `@antv/g2`, this package is used in the chart.
=> Ignore package `@antv/g2` because I think Primate doesn't seem to use the chart.
2. Ant design icons are imported entirely including icons not used in Primate
=> Only import component icons to use in Primate. Refer: https://stackoverflow.com/questions/48721290/ant-design-huge-imports
3. In src/locales, JSON files are being imported directly, so its size is very large (> 2 MB)
=> There is still no better way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #510: Build and packaging improvements
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #510:
URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-665525977
@utchoang I'm okay with removing any dependency such as `@antv/g2` that is not used at all as long as they don't add any regression. The for ant design icons, I think it may be too much effort to find and add icons individually - is there a way to exclude unused icons at build time - otherwise let that be. I think locales is fine, can you look at if we should explore how files are bundled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #510: Build and packaging improvements
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #510:
URL: https://github.com/apache/cloudstack-primate/issues/510
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #510: Build and packaging improvements
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #510:
URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-660876268
@utchoang I'm on holiday, I'll get back to you next week. Meanwhile you may work with @svenvogel @davidjumani for inputs, thanks.
@davidjumani can you collaborate with @utchoang and advise any bugs, tasks if necessary. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org