You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/31 15:35:29 UTC

[GitHub] [skywalking] wu-sheng opened a new pull request #4599: [WIP] 8.0.0 Core Changes

wu-sheng opened a new pull request #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599

This would be a huge pull request, relating to **protocol**, agent and backend. 8.x would be an new core without back forward compatibility.
After the experiences of removing endpoint_inventory, I found out this
strategy is successful.
Especially, we totally get rid of register, so I want to do more.

*SkyWalking 8.0.0*
First, it is already unexpected for me, we have to move to 8.0.0 so
quickly, but after the discussion with @hanahmily , and thinking about this for several days, I think
we have to.

The key chances are following
1. Remove service, service instance, and network address register. The old
register protocols are totally going to be removed.
2. The agent doesn't need to do register anymore. Service name and Service
Instance name are generated by the agent itself, but the extra information,
such as IP, hostname, language, should report to backend separately.
3. Service Traffic should be added just like the endpoint traffic but keep
the time bucket as we need accurate service name in the given duration
4. Service Instance Traffic should be added too, with external information,
such as language, hostname.
5. Trace context propagation context should be changed to accept string in
service instance name, endpoint name and network address. This could ease
the agent logic, but also, requires changes in all language agent and
plugin test tool,
6. Trace report protocol requires to change too, in order to adopt the
string.
7. e2e tests have to ignore PHP and LUA at first, and remove the 6.x
compatibility test(doesn't support anymore).

The benefits we will get are
1. Don't worry about the inventory(s) that has been deleted randomly by end
users. (We received a lot of issue reports about this)
2. The upgrade could be easier erasing the whole storage and reboot the new
one. (Users don't feel comfortable about upgrade)
3. No hot-reboot case in the agent side
4. No cache of network address register information in the agent.
5. No service and service instance cache in the OAP
6. No register lock in the OAP
7. No file buffer mechanism in the OAP too, same as no register happens.

In my mind, I think this totally break upgrade is super meaningful and will
be good change. Even we break many things, they are easy to follow.
@mrproliu I think by following this, we need
to change the collaboration header to `sw8` :) As no 7.1.0 release will
happen.

Link to mail list, https://lists.apache.org/thread.html/rda36fa8d191fc5750fc793993c69e14a917138bf97f9c2a461b72811%40%3Cdev.skywalking.apache.org%3E

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2af4552a1bfd6b369894e53b190446adcea9e633&el=desc) will **increase** coverage by `2.15%`.
   > The diff coverage is `15.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4599      +/-   ##
   ==========================================
   + Coverage   26.92%   29.08%   +2.15%     
   ==========================================
     Files        1256     1189      -67     
     Lines       28968    26043    -2925     
     Branches     3958     3500     -458     
   ==========================================
   - Hits         7800     7574     -226     
   + Misses      20455    17787    -2668     
   + Partials      713      682      -31     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rk/trace/component/command/ProfileTaskCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1Byb2ZpbGVUYXNrQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...rk/trace/component/command/TraceIgnoreCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1RyYWNlSWdub3JlQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...agent/core/commands/CommandExecutionException.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `41.66% <ø> (-12.18%)` | :arrow_down: |
   | [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `28.26% <ø> (-8.70%)` | :arrow_down: |
   | [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `71.42% <0.00%> (ø)` | |
   | [...apm/agent/core/context/ids/DistributedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkLmphdmE=) | `0.00% <0.00%> (-69.24%)` | :arrow_down: |
   | ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [778b86e...3186e21](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2af4552a1bfd6b369894e53b190446adcea9e633&el=desc) will **increase** coverage by `2.17%`.
   > The diff coverage is `15.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4599      +/-   ##
   ==========================================
   + Coverage   26.92%   29.09%   +2.17%     
   ==========================================
     Files        1256     1189      -67     
     Lines       28968    26028    -2940     
     Branches     3958     3497     -461     
   ==========================================
   - Hits         7800     7574     -226     
   + Misses      20455    17772    -2683     
   + Partials      713      682      -31     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rk/trace/component/command/ProfileTaskCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1Byb2ZpbGVUYXNrQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...rk/trace/component/command/TraceIgnoreCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1RyYWNlSWdub3JlQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...agent/core/commands/CommandExecutionException.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `41.66% <ø> (-12.18%)` | :arrow_down: |
   | [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `28.26% <ø> (-8.70%)` | :arrow_down: |
   | [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `71.42% <0.00%> (ø)` | |
   | [...apm/agent/core/context/ids/DistributedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkLmphdmE=) | `0.00% <0.00%> (-69.24%)` | :arrow_down: |
   | ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [778b86e...4870e99](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c0825df77560de2195616426141be7f0783633d1&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4599   +/-   ##
   =======================================
     Coverage   29.15%   29.15%           
   =======================================
     Files        1190     1190           
     Lines       25970    25970           
     Branches     3474     3474           
   =======================================
     Hits         7572     7572           
     Misses      17716    17716           
     Partials      682      682           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [c0825df...c0825df](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3bc6970dab0c12542a2893c1f8ce48b2d627ca5f&el=desc) will **increase** coverage by `1.83%`.
   > The diff coverage is `14.58%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4599      +/-   ##
   ==========================================
   + Coverage   26.92%   28.76%   +1.83%     
   ==========================================
     Files        1256     1192      -64     
     Lines       28968    26005    -2963     
     Branches     3958     3477     -481     
   ==========================================
   - Hits         7801     7480     -321     
   + Misses      20455    17845    -2610     
   + Partials      712      680      -32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...apm/toolkit/opentracing/SkywalkingSpanBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtb3BlbnRyYWNpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvb3BlbnRyYWNpbmcvU2t5d2Fsa2luZ1NwYW5CdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rk/trace/component/command/ProfileTaskCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1Byb2ZpbGVUYXNrQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...rk/trace/component/command/TraceIgnoreCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1RyYWNlSWdub3JlQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...agent/core/commands/CommandExecutionException.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `41.66% <ø> (-12.18%)` | :arrow_down: |
   | [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `28.26% <ø> (-8.70%)` | :arrow_down: |
   | [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `71.42% <0.00%> (ø)` | |
   | ... and [350 more](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [d85760a...d85760a](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

kezhenxu94 commented on a change in pull request #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#discussion_r402402116
 
 

 ##########
 File path: oap-server/server-bootstrap/src/main/resources/component-libraries.yml
 ##########
 @@ -29,6 +29,9 @@
 # ######
 # Languages declare which languages are using this component. Multi languages should be separated by `,`
 
+Unknown:
+  id: 0
+  language: ALl
 
 Review comment:
   TODO

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

kezhenxu94 commented on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-611468905
 
 
   Mark it as "Ready for review" as the test cases should be fixed now, and move to next step if anyone will review the code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-607000357
 
 
   The codes level key changes are
   
   1. Set up traffic for service and service instance. Service Inventory and Instance Inventory are removed.
   2. Add ServiceInstanceProperties as a new source. 
   3. Remove Month as downsamping and query step.
   ...
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

wu-sheng edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-607540654
 
 
   @kezhenxu94 @ascrutae @arugal @heyanlong @ElderJames 
   
   New protocol
   - https://github.com/apache/skywalking/blob/v8-core/docs/en/protocols/Skywalking-Cross-Process-Propagation-Headers-Protocol-v3.md
   - https://github.com/apache/skywalking/blob/v8-core/docs/en/protocols/Trace-Data-Protocol-v3.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-610119981
 
 
   @BFergerson Please notice this PR, as you want to move the vert.x case in the main repo too.
   
   We are changing the protocol, to make the backend has better performance and agent implementation easier. Read this #4595 as step one and this PR as step two, you will have more context.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng edited a comment on issue #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

wu-sheng edited a comment on issue #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-611499300

# Summary
This pull request is open for 10 days, and I worked on this 2 weeks ago. Thanks everyone to help making this PR and tests work now.

Here are the list of changes we made in this pull request. Top 3 are the principle changes, others are following these principles.
1. New agent and mesh report protocol.
1. New agent header protocol.
1. Service register, instance register and network address register have been removed permanently.
1. Service traffic, instance traffic and network alias metrics are added to replace the service, instance and network address inventory.
1. Register process has been removed.
1. Metrics stream process supports insert only mode, especially for traffic entities.
1. Metrics stream process supports no-downsampling mode for traffic entities and network alias.
1. Remove all register mechanism and cache in the java agent.
1. Remove MONTH step in GraphQL query.
1. Update UI to remove MONTH step query, the max query range is 60 days now.
1. Simplify the TTL to metrics and record. And the unit has been formatted in Day unit. No specific TTL for ElasticSearch storage.
1. Buffer mechanism of trace receiver and mesh receiver has been removed due to no register.
1. New service id, instance id and endpoint id rules, including service relation, instance relation and endpoint relation id rules.
1. Java agent support `keep tracing` mode, meaning, agent generating tracing context even the backend is unconnected/unavailable.
1. Plugin test tool up to date, in order to support new protocol.
1. Plugin tests expected data files updated.
1. E2E tests updated.
1. Telemetry of Grafana config has been merged into one.
1. Documentation updates.
1. [TBD] InfluxDB storage implementation is not available, need @dmsolr to fix later, in order to reduce the master change block by this PR.

FYI @apache/skywalking-committers

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-611499300

# Summary
This pull request is open for 10 days, and I worked on this 2 weeks ago. Thanks everyone to help making this PR and tests work now.

Here are the list of changes we made in this pull request. Top 3 are the principle changes, others are following these principles.
1. New agent and mesh report protocol.
1. New agent header protocol.
1. Service register, instance register and network address register have been removed permanently.
1. Service traffic, instance traffic and network alias metrics are added to replace the service, instance and network address inventory.
1. Register process has been removed.
1. Metrics stream process supports insert only mode, especially for traffic entities.
1. Metrics stream process supports no-downsampling mode for traffic entities and network alias.
1. Remove all register mechanism and cache in the java agent.
1. Remove MONTH step in GraphQL query.
1. Update UI to remove MONTH step query, the max query range is 60 days now.
1. Simplify the TTL to metrics and record. And the unit has been formatted in Day unit. No specific TTL for ElasticSearch storage.
1. Buffer mechanism of trace receiver and mesh receiver has been removed due to no register.
1. New service id, instance id and endpoint id rules, including service relation, instance relation and endpoint relation id rules.
1. Java agent support `keep tracing` mode, meaning, agent generating tracing context even the backend is unconnected/unavailable.
1. Plugin test tool up to date, in order to support new protocol.
1. Plugin tests expected data files updated.
1. E2E tests updated.
1. [TBD] InfluxDB storage implementation is not available, need @dmsolr to fix later, in order to reduce the master change block by this PR.

FYI @apache/skywalking-committers

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-611818183
 
 
   @kezhenxu94 I am adjusting some documentations, after that, I will merge this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3bc6970dab0c12542a2893c1f8ce48b2d627ca5f&el=desc) will **increase** coverage by `1.83%`.
   > The diff coverage is `14.58%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4599      +/-   ##
   ==========================================
   + Coverage   26.92%   28.76%   +1.83%     
   ==========================================
     Files        1256     1192      -64     
     Lines       28968    26007    -2961     
     Branches     3958     3477     -481     
   ==========================================
   - Hits         7801     7480     -321     
   + Misses      20455    17847    -2608     
   + Partials      712      680      -32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...apm/toolkit/opentracing/SkywalkingSpanBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtb3BlbnRyYWNpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvb3BlbnRyYWNpbmcvU2t5d2Fsa2luZ1NwYW5CdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rk/trace/component/command/ProfileTaskCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1Byb2ZpbGVUYXNrQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...rk/trace/component/command/TraceIgnoreCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1RyYWNlSWdub3JlQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...agent/core/commands/CommandExecutionException.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `41.66% <ø> (-12.18%)` | :arrow_down: |
   | [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `28.26% <ø> (-8.70%)` | :arrow_down: |
   | [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `71.42% <0.00%> (ø)` | |
   | ... and [350 more](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [a02b0ef...a02b0ef](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/dd39d7536543ac00ee4834cf8dcbfcf5ca2c1615&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4599   +/-   ##
   =======================================
     Coverage   29.13%   29.13%           
   =======================================
     Files        1192     1192           
     Lines       25983    25983           
     Branches     3472     3472           
   =======================================
     Hits         7570     7570           
     Misses      17731    17731           
     Partials      682      682           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [dd39d75...dd39d75](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2af4552a1bfd6b369894e53b190446adcea9e633&el=desc) will **increase** coverage by `2.18%`.
   > The diff coverage is `15.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4599      +/-   ##
   ==========================================
   + Coverage   26.92%   29.11%   +2.18%     
   ==========================================
     Files        1256     1189      -67     
     Lines       28968    26018    -2950     
     Branches     3958     3496     -462     
   ==========================================
   - Hits         7800     7574     -226     
   + Misses      20455    17762    -2693     
   + Partials      713      682      -31     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rk/trace/component/command/ProfileTaskCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1Byb2ZpbGVUYXNrQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...rk/trace/component/command/TraceIgnoreCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1RyYWNlSWdub3JlQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...agent/core/commands/CommandExecutionException.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `41.66% <ø> (-12.18%)` | :arrow_down: |
   | [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `28.26% <ø> (-8.70%)` | :arrow_down: |
   | [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `71.42% <0.00%> (ø)` | |
   | [...apm/agent/core/context/ids/DistributedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkLmphdmE=) | `0.00% <0.00%> (-69.24%)` | :arrow_down: |
   | ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [2af4552...baf05c9](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bb85985c11f35b66fbf512df76cf0187cb481cc0&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4599   +/-   ##
   =======================================
     Coverage   29.13%   29.13%           
   =======================================
     Files        1192     1192           
     Lines       25983    25983           
     Branches     3472     3472           
   =======================================
     Hits         7570     7570           
     Misses      17731    17731           
     Partials      682      682           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [bb85985...bb85985](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

wu-sheng edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-607000357
 
 
   The codes level key changes are
   
   1. Set up traffic for service and service instance. Service Inventory and Instance Inventory are removed.
   1. Add ServiceInstanceProperties as a new source. 
   1. Remove Month as downsamping and query step.
   1. InfluxDB implementation doesn't depend on H2/MySQL, there is no metadb concept anymore. @dmsolr . I just made InfluxDB compiling passed, you need to add metadata query implementation.
   1. Service Instance Update source is created for properties and heartbeat update.
   ...
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/8e1856640da4e3c6bb6a3128e364996ecf7ea714&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4599   +/-   ##
   =======================================
     Coverage   28.76%   28.76%           
   =======================================
     Files        1192     1192           
     Lines       26006    26006           
     Branches     3477     3477           
   =======================================
     Hits         7480     7480           
     Misses      17846    17846           
     Partials      680      680           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [8e18566...8e18566](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/c7a6e01bf3784b3bba5b87d9ac91cc36fd7ae48d&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4599   +/-   ##
   =======================================
     Coverage   29.15%   29.15%           
   =======================================
     Files        1190     1190           
     Lines       25968    25968           
     Branches     3474     3474           
   =======================================
     Hits         7572     7572           
     Misses      17714    17714           
     Partials      682      682           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [c7a6e01...c7a6e01](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2af4552a1bfd6b369894e53b190446adcea9e633&el=desc) will **increase** coverage by `2.23%`.
   > The diff coverage is `15.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4599      +/-   ##
   ==========================================
   + Coverage   26.92%   29.15%   +2.23%     
   ==========================================
     Files        1256     1190      -66     
     Lines       28968    25968    -3000     
     Branches     3958     3474     -484     
   ==========================================
   - Hits         7800     7572     -228     
   + Misses      20455    17714    -2741     
   + Partials      713      682      -31     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...apm/toolkit/opentracing/SkywalkingSpanBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtb3BlbnRyYWNpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvb3BlbnRyYWNpbmcvU2t5d2Fsa2luZ1NwYW5CdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rk/trace/component/command/ProfileTaskCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1Byb2ZpbGVUYXNrQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...rk/trace/component/command/TraceIgnoreCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1RyYWNlSWdub3JlQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...agent/core/commands/CommandExecutionException.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `41.66% <ø> (-12.18%)` | :arrow_down: |
   | [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `28.26% <ø> (-8.70%)` | :arrow_down: |
   | [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `71.42% <0.00%> (ø)` | |
   | ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [7be6a5b...7be6a5b](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

wu-sheng edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-607000357
 
 
   The codes level key changes are
   
   1. Set up traffic for service and service instance. Service Inventory and Instance Inventory are removed.
   1. Add ServiceInstanceProperties as a new source. 
   1. Remove Month as downsamping and query step.
   1. InfluxDB implementation doesn't depend on H2/MySQL, there is no metadb concept anymore.
   ...
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-607540654
 
 
   @kezhenxu94 @ascrutae @arugal @heyanlong @ElderJames 
   
   New protocol
   - https://github.com/apache/skywalking/blob/8.x-core/docs/en/protocols/Skywalking-Cross-Process-Propagation-Headers-Protocol-v3.md
   - https://github.com/apache/skywalking/blob/8.x-core/docs/en/protocols/Trace-Data-Protocol-v3.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on a change in pull request #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#discussion_r406157318
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
 ##########
 @@ -324,14 +324,7 @@ public AbstractSpan createExitSpan(final String operationName, final String remo
             exitSpan = parentSpan;
         } else {
             final int parentSpanId = parentSpan == null ? -1 : parentSpan.getSpanId();
-            if (StringUtil.isEmpty(remotePeer)) {
 
 Review comment:
   This deletion actually is not related to this PR. The lazy peer initialization is another feature :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609006210
 
 
   @apache/skywalking-committers , I just made the project package passed. Now we could move on the core tests.
   
   1. I will continue working on local testing including H2, MySQL and ElasticSearch 6.
   1. @dmsolr Please help on agent plugin tests and InfluxDB storage implementation.
   1. @arugal Please help on go2sky project
   1. @heyanlong Please help on PHP project
   1. @elderjames Please help on .net project
   1. @ascrutae Please help on nodejs project.
   1. @kezhenxu94 Please help on testing and new e2e setup
   1. @mrproliu Please help on backend testing, especially profiling and LUA agent test.
   1. @JaredTan95 Please help on backend testing.
   1. @hanahmily Please run tests on mesh case after the above are done.
   1. @TinyAllen @Fine0830 Please remove the `month` step support when UI time selector choose more than one month. In this case, still set to days, and Max days should be 60 days. The `month` step has been removed from the GraphQL.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-611813113
 
 
   @kezhenxu94 Are you going to do code level review?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng merged pull request #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

wu-sheng merged pull request #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

kezhenxu94 commented on a change in pull request #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#discussion_r402402116
 
 

 ##########
 File path: oap-server/server-bootstrap/src/main/resources/component-libraries.yml
 ##########
 @@ -29,6 +29,9 @@
 # ######
 # Languages declare which languages are using this component. Multi languages should be separated by `,`
 
+Unknown:
+  id: 0
+  language: ALl
 
 Review comment:
   TODO

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3bc6970dab0c12542a2893c1f8ce48b2d627ca5f&el=desc) will **increase** coverage by `1.85%`.
   > The diff coverage is `15.07%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4599      +/-   ##
   ==========================================
   + Coverage   26.92%   28.78%   +1.85%     
   ==========================================
     Files        1256     1192      -64     
     Lines       28968    26007    -2961     
     Branches     3958     3477     -481     
   ==========================================
   - Hits         7801     7486     -315     
   + Misses      20455    17841    -2614     
   + Partials      712      680      -32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...apm/toolkit/opentracing/SkywalkingSpanBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtb3BlbnRyYWNpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvb3BlbnRyYWNpbmcvU2t5d2Fsa2luZ1NwYW5CdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
   | [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rk/trace/component/command/ProfileTaskCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1Byb2ZpbGVUYXNrQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...rk/trace/component/command/TraceIgnoreCommand.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL1RyYWNlSWdub3JlQ29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...agent/core/commands/CommandExecutionException.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `41.66% <ø> (-12.18%)` | :arrow_down: |
   | [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `28.26% <ø> (-8.70%)` | :arrow_down: |
   | [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `71.42% <0.00%> (ø)` | |
   | ... and [352 more](https://codecov.io/gh/apache/skywalking/pull/4599/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [8f6fa9f...8f6fa9f](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on issue #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

kezhenxu94 commented on issue #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-611815791
 
 
   > @kezhenxu94 Are you going to do code level review?
   
   I can do another round of review recently, but that’s not a blocker to merge this, it looks good to me generally, just merge it if necessary 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

wu-sheng edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-607000357
 
 
   The codes level key changes are
   
   1. Set up traffic for service and service instance. Service Inventory and Instance Inventory are removed.
   1. Add ServiceInstanceProperties as a new source. 
   1. Remove Month as downsamping and query step.
   1. InfluxDB implementation doesn't depend on H2/MySQL, there is no metadb concept anymore. @dmsolr . I just made InfluxDB compiling passed, you need to add metadata query implementation.
   1. Service Instance Update source is created for properties and heartbeat update.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4599: Make 8.0.0 Core available. New protocol and register removed.

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on a change in pull request #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#discussion_r406157318
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
 ##########
 @@ -324,14 +324,7 @@ public AbstractSpan createExitSpan(final String operationName, final String remo
             exitSpan = parentSpan;
         } else {
             final int parentSpanId = parentSpan == null ? -1 : parentSpan.getSpanId();
-            if (StringUtil.isEmpty(remotePeer)) {
 
 Review comment:
   This deletion actually is not related to this PR. The lazy peer initialization is another feature :) @kezhenxu94 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4599: [WIP] 8.0.0 Core Changes
URL: https://github.com/apache/skywalking/pull/4599#issuecomment-609445132
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=h1) Report
   > Merging [#4599](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/8bbb5c24c50a4b29631129e03277e534301c5fb4&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4599/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4599   +/-   ##
   =======================================
     Coverage   29.13%   29.13%           
   =======================================
     Files        1192     1192           
     Lines       25983    25983           
     Branches     3472     3472           
   =======================================
     Hits         7571     7571           
     Misses      17731    17731           
     Partials      681      681           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=footer). Last update [8bbb5c2...8bbb5c2](https://codecov.io/gh/apache/skywalking/pull/4599?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services