You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/11 01:08:44 UTC

[GitHub] [cordova-android] breautek opened a new pull request #1048: breaking: remove keystore password prompt

breautek opened a new pull request #1048:
URL: https://github.com/apache/cordova-android/pull/1048


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Closes #1021 
   
   ### Description
   <!-- Describe your changes in detail -->
   Removes the gradle keystore password prompt implementation. It was buggy and never worked well for a significant period of time, due to how gradle daemonizes its processes. 
   
   **This is a breaking change**
   
   Intended for the v10 milestone release.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   `npm test` and manual testing with `build.json` file.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu merged pull request #1048: breaking: remove keystore password prompt

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1048:
URL: https://github.com/apache/cordova-android/pull/1048


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org