[GitHub] [tvm] leandron commented on a change in pull request #10247: [docker] Update CI to Python 3.7 and Ubuntu 18

[GitBox <gi...@apache.org>]

leandron commented on a change in pull request #10247:
URL: https://github.com/apache/tvm/pull/10247#discussion_r806665488



##########
File path: docker/install/ubuntu1804_install_python.sh
##########
@@ -23,10 +23,10 @@ set -o pipefail
 # install python and pip, don't modify this, modify install_python_package.sh
 apt-get update
 apt-get install -y software-properties-common
-apt-get install -y python3-dev python3-setuptools
+apt-get install -y python3.7 python3.7-dev python3-pip
 
 # Install pip
-cd /tmp && wget -q https://bootstrap.pypa.io/pip/3.6/get-pip.py && python3 get-pip.py
+update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.7 1
 
 # Pin pip and setuptools versions
 pip3 install pip==19.3.1 setuptools==58.4.0

Review comment:
       In moving to Python 3.7, do we still need to have this pinned to these version or can we pin them to something newer?

##########
File path: docker/install/ubuntu_install_llvm.sh
##########
@@ -46,4 +47,4 @@ echo deb-src http://apt.llvm.org/xenial/ llvm-toolchain-xenial main\
      >> /etc/apt/sources.list.d/llvm.list
 
 wget -q -O - http://apt.llvm.org/llvm-snapshot.gpg.key|sudo apt-key add -
-apt-get update && apt-get install -y llvm-4.0 llvm-9 llvm-8 llvm-7 clang-9 libclang-9-dev clang-8 libclang-8-dev clang-7 libclang-7-dev
+apt-get install -y llvm-4.0 llvm-9 llvm-8 llvm-7 clang-9 libclang-9-dev clang-8 libclang-8-dev clang-7 libclang-7-dev

Review comment:
       Maybe a separate issue, but do we still need LLVM 4?

##########
File path: docker/install/ubuntu_install_caffe.sh
##########
@@ -16,17 +16,15 @@
 # specific language governing permissions and limitations
 # under the License.
 
-set -e
-set -u
-set -o pipefail
+set -euxo pipefail

Review comment:
       I suggest keeping the pattern we have in other script and avoid the `-x` unless debugging.

##########
File path: docker/install/ubuntu_install_boost.sh
##########
@@ -0,0 +1,30 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -euxo pipefail
+
+curl -LO https://boostorg.jfrog.io/artifactory/main/release/1.67.0/source/boost_1_67_0.tar.gz
+tar -xf boost_1_67_0.tar.gz

Review comment:
       Good point. I'd suggest using the little `trap cleanup` template, similar to what we have in other scripts:
   
   https://github.com/apache/tvm/blob/0009a308d82a321f2399923ab14b4c088461b4f2/docker/install/ubuntu_download_arm_compute_lib_binaries.sh#L45-L54
   
   This will have a few hundred MB in storage, to our already quite bg Docker image.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org