You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by su...@apache.org on 2015/02/12 15:55:55 UTC

trafficserver git commit: [TS-3294]: Fix forward_null defect

Repository: trafficserver
Updated Branches:
  refs/heads/master 453e3047b -> 8b6eae88f


[TS-3294]: Fix forward_null defect

Coverity CID#1269606


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/8b6eae88
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/8b6eae88
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/8b6eae88

Branch: refs/heads/master
Commit: 8b6eae88fff6187b920a757ae0a72fe810cb1d56
Parents: 453e304
Author: Sudheer Vinukonda <su...@yahoo-inc.com>
Authored: Thu Feb 12 14:55:07 2015 +0000
Committer: Sudheer Vinukonda <su...@yahoo-inc.com>
Committed: Thu Feb 12 14:55:07 2015 +0000

----------------------------------------------------------------------
 proxy/logstats.cc | 37 +++++++++++++++++++------------------
 1 file changed, 19 insertions(+), 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/8b6eae88/proxy/logstats.cc
----------------------------------------------------------------------
diff --git a/proxy/logstats.cc b/proxy/logstats.cc
index 583218a..fdd4417 100644
--- a/proxy/logstats.cc
+++ b/proxy/logstats.cc
@@ -700,26 +700,27 @@ CommandLineArgs::parse_arguments(const char** argv)
 
       for (tok = strtok_r(buffer, "&", &sep_ptr); tok != NULL;) {
         val = strchr(tok, '=');
-        if (val)
+        if (val) {
           *(val++) = '\0';
-        if (0 == strncmp(tok, "origin_list", 11)) {
-          ink_strlcpy(origin_list, val, sizeof(origin_list));
-        } else if (0 == strncmp(tok, "state_tag", 9)) {
-          ink_strlcpy(state_tag, val, sizeof(state_tag));
-        } else if (0 == strncmp(tok, "max_origins", 11)) {
-          max_origins = strtol(val, NULL, 10);
-        } else if (0 == strncmp(tok, "urls", 4)) {
-          urls = strtol(val, NULL, 10);
-        } else if (0 == strncmp(tok, "show_urls", 9)) {
-          show_urls = strtol(val, NULL, 10);
-        } else if (0 == strncmp(tok, "as_object", 9)) {
-          as_object = strtol(val, NULL, 10);
-        } else if (0 == strncmp(tok, "min_hits", 8)) {
-          min_hits = strtol(val, NULL, 10);
-        } else if (0 == strncmp(tok, "incremental", 11)) {
-          incremental = strtol(val, NULL, 10);
-        } else {
+          if (0 == strncmp(tok, "origin_list", 11)) {
+            ink_strlcpy(origin_list, val, sizeof(origin_list));
+          } else if (0 == strncmp(tok, "state_tag", 9)) {
+            ink_strlcpy(state_tag, val, sizeof(state_tag));
+          } else if (0 == strncmp(tok, "max_origins", 11)) {
+            max_origins = strtol(val, NULL, 10);
+          } else if (0 == strncmp(tok, "urls", 4)) {
+            urls = strtol(val, NULL, 10);
+          } else if (0 == strncmp(tok, "show_urls", 9)) {
+            show_urls = strtol(val, NULL, 10);
+          } else if (0 == strncmp(tok, "as_object", 9)) {
+            as_object = strtol(val, NULL, 10);
+          } else if (0 == strncmp(tok, "min_hits", 8)) {
+            min_hits = strtol(val, NULL, 10);
+          } else if (0 == strncmp(tok, "incremental", 11)) {
+            incremental = strtol(val, NULL, 10);
+          } else {
           // Unknown query arg.
+          }
         }
 
         tok = strtok_r(NULL, "&", &sep_ptr);