You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/02 07:24:22 UTC

[GitHub] gatorsmile commented on a change in pull request #21826: [SPARK-24872] Replace the symbol '||' of Or operator with 'or'

gatorsmile commented on a change in pull request #21826: [SPARK-24872] Replace the symbol '||' of Or operator with 'or'
URL: https://github.com/apache/spark/pull/21826#discussion_r244672255
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ##########
 @@ -442,7 +442,7 @@ case class Or(left: Expression, right: Expression) extends BinaryOperator with P
 
   override def inputType: AbstractDataType = BooleanType
 
-  override def symbol: String = "||"
+  override def symbol: String = "or"
 
 Review comment:
   So far, yes. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org