You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/05/01 18:07:10 UTC

[kudu-CR] Deflake TestTimeouts.testLowTimeouts

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13202 )

Change subject: Deflake TestTimeouts.testLowTimeouts
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13202/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java:

http://gerrit.cloudera.org:8080/#/c/13202/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java@44
PS1, Line 44:    * TODO(aserbin) this test is flaky; add delays on the server side to make it stable
> Remove this?
+1


http://gerrit.cloudera.org:8080/#/c/13202/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java@59
PS1, Line 59:         // in the case where there is a master election).
nit: add 'The latter captures ServiceUnavailable status from master.'



-- 
To view, visit http://gerrit.cloudera.org:8080/13202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d1a429fe5749c31495e0d10f74a0cfb1e623310
Gerrit-Change-Number: 13202
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 May 2019 18:07:10 +0000
Gerrit-HasComments: Yes