[GitHub] [daffodil-vscode] stricklandrbls commented on a diff in pull request #570: Clear selection data when ephemeral windows close

["stricklandrbls (via GitHub)" <gi...@apache.org>]

stricklandrbls commented on code in PR #570:
URL: https://github.com/apache/daffodil-vscode/pull/570#discussion_r1158618220


##########
src/svelte/src/components/dataEditor.svelte:
##########
@@ -220,6 +220,7 @@ limitations under the License.
         (targetLine == 0 ? 0 : targetLine - 1) * lineHeight
     }
     closeEphemeralWindows()
+    clearDataDisplays()

Review Comment:
   That's how I originally had it set up but there was one instance where we should close the window but not clear. I'm trying to think of what it was.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org