You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/09 20:05:21 UTC
[GitHub] [superset] junlincc opened a new issue #15068: [native-filters]hide time related filters when there's no temporal column in datasets
junlincc opened a new issue #15068:
URL: https://github.com/apache/superset/issues/15068
Hide all 3 time related filters when there's no temporal columns in datasets that support charts on dashboard.
Please test with dashboard that has at least two datasets. 1) both don't have temporal columns, 2) only one has
Edge case: If a dashboard has charts created from dataset A(has temporal column) and charts created from dataset B (without temporal column), when user create a time range filter, charts created from dataset B should be unscoped in the scoping tree by default.
It appears that the COVID dataset doesn't have a temporal column. Which raises the question, we should probably not show a time filter (or time column filter for that matter) if there are no temporal columns available in the target dataset. However, this same problem applies to Filter Box as well, so I propose leaving that to a later PR.
_Originally posted by @villebro in https://github.com/apache/superset/issues/15015#issuecomment-857412274_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org