You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/09 07:29:38 UTC
[GitHub] [incubator-seatunnel] liujinhui1994 opened a new pull request #1213: [hotfix] Delete lombok
liujinhui1994 opened a new pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1213: [hotfix] Delete lombok
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213#issuecomment-1033443581
> lombok, too redundant for a project. @kezhenxu94
When you come to a community you have to learn the community's rules, it's not your own opinion whether Lombok is redundant or not (though some people consider Java codes without Lombok are verbose / redundant and Lombok is a live-saver), you need to discuss with the community when you want to do some changes that effect the developers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liujinhui1994 commented on pull request #1213: [hotfix] Delete lombok
Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213#issuecomment-1033438712
lombok, too redundant for a project. @kezhenxu94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liujinhui1994 commented on pull request #1213: [DISCUSS] Delete lombok
Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213#issuecomment-1033461921
Because considering the subsequent development, lombok will seriously affect the readability and scalability of the code. Of course I will close this PR if it is not needed by the community here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liujinhui1994 edited a comment on pull request #1213: [hotfix] Delete lombok
Posted by GitBox <gi...@apache.org>.
liujinhui1994 edited a comment on pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213#issuecomment-1033438712
lombok, too redundant for a project. Also less readable, so I recommend removing it. @kezhenxu94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liujinhui1994 commented on pull request #1213: [DISCUSS] Delete lombok
Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213#issuecomment-1033464565
@CalvinKirs @kezhenxu94 It has been closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liujinhui1994 closed pull request #1213: [DISCUSS] Delete lombok
Posted by GitBox <gi...@apache.org>.
liujinhui1994 closed pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1213: [hotfix] Delete lombok
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213#issuecomment-1033433887
@liujinhui1994 do you have any issue or mailing list discussion to change this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liujinhui1994 edited a comment on pull request #1213: [DISCUSS] Delete lombok
Posted by GitBox <gi...@apache.org>.
liujinhui1994 edited a comment on pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213#issuecomment-1033464565
@CalvinKirs @kezhenxu94 It's closed, I can open it anytime if needed，thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1213: [DISCUSS] Delete lombok
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213#issuecomment-1033471266
> Because considering the subsequent development,
>> lombok will seriously affect the readability and scalability of the code. Of course I will close this PR if it is not needed by the community here
If you really feel it is necessary, you can initiate a discussion. But I don't agree with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1213: [hotfix] Delete lombok
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1213:
URL: https://github.com/apache/incubator-seatunnel/pull/1213#issuecomment-1033442993
> lombok, too redundant for a project. Also less readable, so I recommend removing it. @kezhenxu94
It's better to be able to discuss in email, I think lombok is good, he makes our code look cleaner, I don't like spending a lot of time in redundant code,.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org