You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by ki...@apache.org on 2022/11/30 14:54:13 UTC

[opennlp] branch master updated: OPENNLP-1341 Make the ConlluPOSSampleStream constructor public

This is an automated email from the ASF dual-hosted git repository.

kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/opennlp.git


The following commit(s) were added to refs/heads/master by this push:
     new 003b73f1 OPENNLP-1341 Make the ConlluPOSSampleStream constructor public
003b73f1 is described below

commit 003b73f1804bb2817a770faac0738f9e7769178c
Author: Martin Wiesner <ma...@hs-heilbronn.de>
AuthorDate: Tue Nov 1 16:48:03 2022 +0100

    OPENNLP-1341 Make the ConlluPOSSampleStream constructor public
    
    - adds missing `public` modifier for `ConlluPOSSampleStream` to be consistent with `ConlluLemmaSampleStream` and similar ones
    - adds missing JavaDoc on 'internal use only' for `ConlluSentenceSampleStreamFactory` and `ConlluTokenSampleStreamFactory`
---
 .../main/java/opennlp/tools/formats/conllu/ConlluPOSSampleStream.java  | 2 +-
 .../tools/formats/conllu/ConlluSentenceSampleStreamFactory.java        | 3 +++
 .../opennlp/tools/formats/conllu/ConlluTokenSampleStreamFactory.java   | 3 +++
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluPOSSampleStream.java b/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluPOSSampleStream.java
index 28dddc08..82e81437 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluPOSSampleStream.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluPOSSampleStream.java
@@ -30,7 +30,7 @@ public class ConlluPOSSampleStream extends FilterObjectStream<ConlluSentence, PO
 
   private final ConlluTagset tagset;
 
-  ConlluPOSSampleStream(ObjectStream<ConlluSentence> samples, ConlluTagset tagset) {
+  public ConlluPOSSampleStream(ObjectStream<ConlluSentence> samples, ConlluTagset tagset) {
     super(samples);
     this.tagset = Objects.requireNonNull(tagset);
   }
diff --git a/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluSentenceSampleStreamFactory.java b/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluSentenceSampleStreamFactory.java
index d1b9ea0d..f39eca11 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluSentenceSampleStreamFactory.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluSentenceSampleStreamFactory.java
@@ -28,6 +28,9 @@ import opennlp.tools.sentdetect.SentenceSample;
 import opennlp.tools.util.InputStreamFactory;
 import opennlp.tools.util.ObjectStream;
 
+/**
+ * <b>Note:</b> Do not use this class, internal use only!
+ */
 public class ConlluSentenceSampleStreamFactory<P> extends AbstractSampleStreamFactory<SentenceSample, P> {
 
   interface Parameters extends BasicFormatParams {
diff --git a/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluTokenSampleStreamFactory.java b/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluTokenSampleStreamFactory.java
index 413ac755..21d8c4af 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluTokenSampleStreamFactory.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluTokenSampleStreamFactory.java
@@ -28,6 +28,9 @@ import opennlp.tools.tokenize.TokenSample;
 import opennlp.tools.util.InputStreamFactory;
 import opennlp.tools.util.ObjectStream;
 
+/**
+ * <b>Note:</b> Do not use this class, internal use only!
+ */
 public class ConlluTokenSampleStreamFactory<P> extends AbstractSampleStreamFactory<TokenSample, P> {
 
   interface Parameters extends BasicFormatParams {