You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/02/20 04:34:08 UTC
[GitHub] [incubator-hudi] smarthi opened a new pull request #1343: HUDI:622:
Remove VisibleForTesting annotation and import from code
smarthi opened a new pull request #1343: HUDI:622: Remove VisibleForTesting annotation and import from code
URL: https://github.com/apache/incubator-hudi/pull/1343
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
Remove @VisibleForTesting annotation as part of Guava cleanup in PR# 1159
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [X] Has a corresponding JIRA in PR title & commit
- [X] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] smarthi commented on issue #1343: [HUDI-622]:
Remove VisibleForTesting annotation and import from code
Posted by GitBox <gi...@apache.org>.
smarthi commented on issue #1343: [HUDI-622]: Remove VisibleForTesting annotation and import from code
URL: https://github.com/apache/incubator-hudi/pull/1343#issuecomment-588636142
> @smarthi Travis is red. Can you check the reason?
Found the issue and fixed it... wait for next Travis CI run to be green before merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1343: [HUDI-622]:
Remove VisibleForTesting annotation and import from code
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1343: [HUDI-622]: Remove VisibleForTesting annotation and import from code
URL: https://github.com/apache/incubator-hudi/pull/1343#issuecomment-588634226
@smarthi Travis is red. Can you check the reason?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua merged pull request #1343: [HUDI-622]:
Remove VisibleForTesting annotation and import from code
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1343: [HUDI-622]: Remove VisibleForTesting annotation and import from code
URL: https://github.com/apache/incubator-hudi/pull/1343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services