You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/21 00:26:26 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42513: [SPARK-44827][PYTHON][TESTS] Fix test when ansi mode enabled

HyukjinKwon commented on code in PR #42513:
URL: https://github.com/apache/spark/pull/42513#discussion_r1299463703


##########
python/pyspark/sql/dataframe.py:
##########
@@ -3793,6 +3793,8 @@ def union(self, other: "DataFrame") -> "DataFrame":
         Example 2: Combining two DataFrames with different schemas
 
         >>> from pyspark.sql.functions import lit
+        >>> old_value = spark.conf.get("spark.sql.ansi.enabled")
+        >>> spark.conf.set("spark.sql.ansi.enabled", "false")

Review Comment:
   can we fix the example instead of disabling?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org