[GitHub] [incubator-pagespeed-mod] Lofesa commented on issue #1966: hint_preload_subresources didn't match rewrite_domains

[GitBox <gi...@apache.org>]

Lofesa commented on issue #1966: hint_preload_subresources didn't match rewrite_domains
URL: https://github.com/apache/incubator-pagespeed-mod/issues/1966#issuecomment-561554387
 
 
   @oschaaf  
   In this issue pagespeed need to rewrite all link headers or only these that are rel=preload?
   If all link headers must be rewrited then a change in incubator-pagespeed-mod/net/instaweb/rewriter/domain_rewrite_filter.cc can be done adding:
   ```
   TryUpdateOneHttpDomainHeader(base_url, server_context, options,
                                  HttpAttributes::kLink, headers);
   ```
   But if only headers with rel=preload  set by pagespeed, then the change must be done at net/instaweb/rewriter/push_preload_filter.cc calling  `DomainRewriteFilter::UpdateDomainHeaders`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services