You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Rui Wang (Jira)" <ji...@apache.org> on 2020/11/23 23:06:00 UTC

[jira] [Commented] (RATIS-1172) DataStreamApi/DataStreamOutput should expose stream close()

    [ https://issues.apache.org/jira/browse/RATIS-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237743#comment-17237743 ] 

Rui Wang commented on RATIS-1172:
---------------------------------

[~szetszwo]

Currently RaftClient exposes "DataStreamApi getDataStreamApi();", and in DataStreamApi, it exposes DataStreamOutput, and in DataStreamOutput it exposes

writeAsync.

 

So why DataStreamApi or DataStreamOutput does not expose close() API? For example, in FileStore, it holds a RaftClient and there we can use the stream API to write, but then after the write, should FileStore to close the stream (I think it should). In current testing, we have solved this problem by casting DataStreamOutput to DataStreamOutputRpc. This approach is not a good one for applicaiton.

 

> DataStreamApi/DataStreamOutput should expose stream close()
> -----------------------------------------------------------
>
>                 Key: RATIS-1172
>                 URL: https://issues.apache.org/jira/browse/RATIS-1172
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)