You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dewrich <gi...@git.apache.org> on 2017/04/13 15:02:45 UTC
[GitHub] incubator-trafficcontrol pull request #467: Modified admin.pl to support the...
GitHub user dewrich opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/467
Modified admin.pl to support the postgres superuser
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dewrich/incubator-trafficcontrol postgres-superuser
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/467.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #467
----
commit 792856424f12656994ca709a8fec519048fed975
Author: Dewayne Richardson <de...@apache.org>
Date: 2017-04-12T20:46:52Z
switched the goose user to be postgres
commit 5f43d7f042b65542ab8c37acfcd04bf8755c8ac7
Author: Dewayne Richardson <de...@apache.org>
Date: 2017-04-12T20:47:19Z
switched the postgres user to be the driver of the admin.pl user
commit 84545f2cfeb0283c9edaaf04fdaf1e0274dd6de3
Author: Dewayne Richardson <de...@apache.org>
Date: 2017-04-12T20:47:36Z
Merge branch 'master' into postgres-superuser
commit 718895cb78060ba985b5b0feeb7cb2a098aebe58
Author: Dewayne Richardson <de...@apache.org>
Date: 2017-04-13T15:01:18Z
added the ability to do a create_super_user
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #467: TC-233 Modified admin.pl to supp...
Posted by dewrich <gi...@git.apache.org>.
Github user dewrich commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/467#discussion_r111629100
--- Diff: traffic_ops/app/db/admin.pl ---
@@ -29,23 +29,44 @@
use YAML qw(LoadFile);
use DBIx::Class::Schema::Loader qw/make_schema_at/;
+use Env;
+use Env qw(HOME);
--- End diff --
yea oversite, fixed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #467: [BACKPORT TC-233] Modified admin...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/467#discussion_r111585182
--- Diff: traffic_ops/app/db/admin.pl ---
@@ -29,23 +29,44 @@
use YAML qw(LoadFile);
use DBIx::Class::Schema::Loader qw/make_schema_at/;
+use Env;
+use Env qw(HOME);
--- End diff --
and why twice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #467: TC-233 Modified admin.pl to supp...
Posted by dewrich <gi...@git.apache.org>.
Github user dewrich commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/467#discussion_r111629504
--- Diff: traffic_ops/app/db/admin.pl ---
@@ -29,23 +29,44 @@
use YAML qw(LoadFile);
use DBIx::Class::Schema::Loader qw/make_schema_at/;
+use Env;
+use Env qw(HOME);
--- End diff --
Actually, I pulled that in from this Perl Doc http://perldoc.perl.org/Env.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #467: TC-233 Modified admin.pl to supp...
Posted by dewrich <gi...@git.apache.org>.
Github user dewrich commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/467#discussion_r111629558
--- Diff: traffic_ops/app/db/admin.pl ---
@@ -29,23 +29,44 @@
use YAML qw(LoadFile);
use DBIx::Class::Schema::Loader qw/make_schema_at/;
+use Env;
+use Env qw(HOME);
--- End diff --
Perl also fails the compile without it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #467: [BACKPORT TC-233] Modified admin...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/467#discussion_r111583751
--- Diff: traffic_ops/app/db/admin.pl ---
@@ -29,23 +29,44 @@
use YAML qw(LoadFile);
use DBIx::Class::Schema::Loader qw/make_schema_at/;
+use Env;
+use Env qw(HOME);
+
my $usage = "\n"
. "Usage: $PROGRAM_NAME [--env (development|test|production|integration)] [arguments]\t\n\n"
. "Example: $PROGRAM_NAME --env=test reset\n\n"
. "Purpose: This script is used to manage database. The environments are\n"
. " defined in the dbconf.yml, as well as the database names.\n\n"
- . "arguments: \n\n"
+ . "NOTE: \n"
+ . "Postgres Superuser: The 'postgres' superuser needs to be created to run $PROGRAM_NAME and setup databases.\n"
+ . "If the 'postgres' superuser has not been created or password has not been set then run the following commands accordingly. \n\n"
+ . "Create the 'postgres' user as a super user (if not created):\n\n"
+ . " \$ createuser postgres --superuser --createrole --createdb --login --pwprompt\n\n"
+ . "Postgres Password: file allows for easy command line access by defaulting the user and password for the database\n"
+ . "without prompts.\n\n"
--- End diff --
didn't understand previous 2 lines until I saw mention of .pgpass below. That probably should be more clear
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #467: [BACKPORT TC-233] Modified admin...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/467#discussion_r111583451
--- Diff: traffic_ops/app/db/admin.pl ---
@@ -29,23 +29,44 @@
use YAML qw(LoadFile);
use DBIx::Class::Schema::Loader qw/make_schema_at/;
+use Env;
+use Env qw(HOME);
--- End diff --
is it worth bringing in this module for a single env var?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #467: TC-233 Modified admin.pl to supp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---