You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/11/16 18:51:53 UTC
[PR] HDDS-11733. Remove okio versioning and unused okhttp dependency [ozone]
adoroszlai opened a new pull request, #7447:
URL: https://github.com/apache/ozone/pull/7447
## What changes were proposed in this pull request?
- `okio` is transitive-only, versioning is not needed
- `okhttp` 2.7.5 is not required by Ozone or any dependencies, can be removed
https://issues.apache.org/jira/browse/HDDS-11733
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/11868908490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11733. Remove okio versioning and unused okhttp dependency [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7447:
URL: https://github.com/apache/ozone/pull/7447#issuecomment-2490209423
> The LICENSE.txt under hadoop-ozone/dist/src/main/license/bin mentioned these two package.
Thanks @ChenSammi for checking.
```
com.squareup.okhttp3:okhttp
com.squareup.okio:okio
```
We still need these entries (note that `okhttp` is the v3 one), since they are part of the binary distribution:
```
share/ozone/lib/okhttp.jar
share/ozone/lib/okio.jar
```
But while verifying, I just noticed that some items introduced by okio upgrade in #5063 are missing from the LICENSE. Updated now in 4ff2214da279481c6c91864823247188e030f954.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11733. Remove okio versioning and unused okhttp dependency [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7447:
URL: https://github.com/apache/ozone/pull/7447#issuecomment-2490463932
Thanks @ChenSammi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11733. Remove okio versioning and unused okhttp dependency [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7447:
URL: https://github.com/apache/ozone/pull/7447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11733. Remove okio versioning and unused okhttp dependency [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #7447:
URL: https://github.com/apache/ozone/pull/7447#issuecomment-2490176196
The LICENSE.txt under hadoop-ozone/dist/src/main/license/bin mentioned these two package. Shall we manually remove them from the LICENSE.txt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org