You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/24 17:29:07 UTC

[GitHub] [airflow] ashb commented on a change in pull request #21798: WIP: Change BaseOperatorLink interface to take a ti_key, not a datetime

ashb commented on a change in pull request #21798:
URL: https://github.com/apache/airflow/pull/21798#discussion_r814107578



##########
File path: airflow/providers/qubole/operators/qubole.py
##########
@@ -39,7 +41,13 @@ class QDSLink(BaseOperatorLink):
 
     name = 'Go to QDS'
 
-    def get_link(self, operator: BaseOperator, dttm: datetime) -> str:
+    def get_link(
+        self,
+        operator: "AbstractOperator",
+        dttm: Optional[datetime] = None,
+        *,
+        ti_key: Optional["TaskInstanceKey"] = None,
+    ) -> str:

Review comment:
       I think this signature and logic should be backwards and forwards compatible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org