[jira] Commented: (STR-3020) AbstractCreateAction emits error unnecessarily

["Paul Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/struts/browse/STR-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40755 ] 

Paul Benedict commented on STR-3020:
------------------------------------

Is this what you recommend?
if (type == null && command == null) { 


> AbstractCreateAction emits error unnecessarily
> ----------------------------------------------
>
>                 Key: STR-3020
>                 URL: https://issues.apache.org/struts/browse/STR-3020
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.3.8
>            Reporter: ori
>            Priority: Minor
>             Fix For: 1.3.9, 1.4.0
>
>
> Some ActionConfigs specify a command class instead of an action class.
> The following code in in AbstractCreateAction will emit an error even though there's a valid command class specified and no error should be reported to the application developer.
> AbstractCreateAction .java
> --------------
> ...
> 78:    if (type == null) {
> 79:            if ((actionConfig.getForward() == null)
> 80:                && (actionConfig.getInclude() == null)) {
> 81:                LOG.error("no type for " + actionConfig.getPath());
> 82:            }
> ...
> --------------

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.