You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Anders Janmyr (JIRA)" <ji...@apache.org> on 2007/12/05 11:43:43 UTC
[jira] Created: (WICKET-1207) AjaxEditableChoiceLabel should not be
MultiLineLabel (wrapped in p)
AjaxEditableChoiceLabel should not be MultiLineLabel (wrapped in p)
-------------------------------------------------------------------
Key: WICKET-1207
URL: https://issues.apache.org/jira/browse/WICKET-1207
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Affects Versions: 1.3.0-rc1
Reporter: Anders Janmyr
Priority: Trivial
When an AjaxEditableChoiceLabel is rendered it is rendered as a MultiLineLabel.
This adds an unnecessary paragraph around.
A fix is simple: Replace MultiLineLabel with Label in the newLabel method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1207) AjaxEditableChoiceLabel should not be
MultiLineLabel (wrapped in p)
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1207:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc3)
1.3.0-final
> AjaxEditableChoiceLabel should not be MultiLineLabel (wrapped in p)
> -------------------------------------------------------------------
>
> Key: WICKET-1207
> URL: https://issues.apache.org/jira/browse/WICKET-1207
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc1
> Reporter: Anders Janmyr
> Assignee: Johan Compagner
> Priority: Trivial
> Fix For: 1.3.0-final
>
>
> When an AjaxEditableChoiceLabel is rendered it is rendered as a MultiLineLabel.
> This adds an unnecessary paragraph around.
> A fix is simple: Replace MultiLineLabel with Label in the newLabel method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1207) AjaxEditableChoiceLabel should not be
MultiLineLabel (wrapped in p)
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner closed WICKET-1207.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-rc3
Assignee: Johan Compagner (was: Eelco Hillenius)
deleted the newLabel method all together so that it defaults to the AjaxEditableLabel
> AjaxEditableChoiceLabel should not be MultiLineLabel (wrapped in p)
> -------------------------------------------------------------------
>
> Key: WICKET-1207
> URL: https://issues.apache.org/jira/browse/WICKET-1207
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc1
> Reporter: Anders Janmyr
> Assignee: Johan Compagner
> Priority: Trivial
> Fix For: 1.3.0-rc3
>
>
> When an AjaxEditableChoiceLabel is rendered it is rendered as a MultiLineLabel.
> This adds an unnecessary paragraph around.
> A fix is simple: Replace MultiLineLabel with Label in the newLabel method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1207) AjaxEditableChoiceLabel should not
be MultiLineLabel (wrapped in p)
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner reassigned WICKET-1207:
---------------------------------------
Assignee: Eelco Hillenius
I guess its by design that its a multiline label because choices can be multi selected?
What i do find strange is th difference between the other 2 AjaxEditableXXX components for example this check:
protected void onComponentTagBody(MarkupStream markupStream, ComponentTag openTag)
{
Object modelObject = getModelObject();
if (modelObject == null || "".equals(modelObject))
{
replaceComponentTagBody(markupStream, openTag, defaultNullLabel());
}
else
{
super.onComponentTagBody(markupStream, openTag);
}
}
eelco can have a quick look
> AjaxEditableChoiceLabel should not be MultiLineLabel (wrapped in p)
> -------------------------------------------------------------------
>
> Key: WICKET-1207
> URL: https://issues.apache.org/jira/browse/WICKET-1207
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc1
> Reporter: Anders Janmyr
> Assignee: Eelco Hillenius
> Priority: Trivial
>
> When an AjaxEditableChoiceLabel is rendered it is rendered as a MultiLineLabel.
> This adds an unnecessary paragraph around.
> A fix is simple: Replace MultiLineLabel with Label in the newLabel method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1207) AjaxEditableChoiceLabel should not
be MultiLineLabel (wrapped in p)
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552274 ]
Johan Compagner commented on WICKET-1207:
-----------------------------------------
hmm i see that it is by default a DropDown so single select choice
Then in my eyes the multply label doesn't make sense yes.
> AjaxEditableChoiceLabel should not be MultiLineLabel (wrapped in p)
> -------------------------------------------------------------------
>
> Key: WICKET-1207
> URL: https://issues.apache.org/jira/browse/WICKET-1207
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.3.0-rc1
> Reporter: Anders Janmyr
> Assignee: Eelco Hillenius
> Priority: Trivial
>
> When an AjaxEditableChoiceLabel is rendered it is rendered as a MultiLineLabel.
> This adds an unnecessary paragraph around.
> A fix is simple: Replace MultiLineLabel with Label in the newLabel method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.