You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/08/26 08:41:41 UTC
Review Request 37789: Refer to shared task_configs table for job
updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37789/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-647
https://issues.apache.org/jira/browse/AURORA-647
Repository: aurora
Description
-------
Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 7728684560d3111edaa2e29d9738f71bc1d7a9ff
src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4
src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e
src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5
Diff: https://reviews.apache.org/r/37789/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 37789: Refer to shared task_configs table for job
updates.
Posted by Bill Farner <wf...@apache.org>.
> On Aug. 26, 2015, 11:18 a.m., Maxim Khutornenko wrote:
> > Any noticable impact on JobDetailsBenchmark after this change?
Thanks for the nudge - turns out this patch broke that test due to schema requirements. Fixed, and will put results in the testing field.
> On Aug. 26, 2015, 11:18 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 194
> > <https://reviews.apache.org/r/37789/diff/1/?file=1053036#file1053036line194>
> >
> > kill newline
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37789/#review96563
-----------------------------------------------------------
On Aug. 25, 2015, 11:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37789/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 11:41 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-647
> https://issues.apache.org/jira/browse/AURORA-647
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 7728684560d3111edaa2e29d9738f71bc1d7a9ff
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5
>
> Diff: https://reviews.apache.org/r/37789/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37789: Refer to shared task_configs table for job
updates.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37789/#review96563
-----------------------------------------------------------
Ship it!
Any noticable impact on JobDetailsBenchmark after this change?
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql (line 103)
<https://reviews.apache.org/r/37789/#comment152080>
kill newline
- Maxim Khutornenko
On Aug. 26, 2015, 6:41 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37789/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 6:41 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-647
> https://issues.apache.org/jira/browse/AURORA-647
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 7728684560d3111edaa2e29d9738f71bc1d7a9ff
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5
>
> Diff: https://reviews.apache.org/r/37789/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37789: Refer to shared task_configs table for job
updates.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37789/#review96529
-----------------------------------------------------------
Ship it!
Master (d901347) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 26, 2015, 6:41 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37789/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 6:41 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-647
> https://issues.apache.org/jira/browse/AURORA-647
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 7728684560d3111edaa2e29d9738f71bc1d7a9ff
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5
>
> Diff: https://reviews.apache.org/r/37789/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37789: Refer to shared task_configs table for job
updates.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37789/#review96995
-----------------------------------------------------------
Ship it!
Master (356eeac) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 29, 2015, 3:45 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37789/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2015, 3:45 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-647
> https://issues.apache.org/jira/browse/AURORA-647
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 48bee5068db5aeacf181c76c4d3add71d045c8a9
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java fd46c3f0718c7c60b7b80b903545490cd7727204
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5
>
> Diff: https://reviews.apache.org/r/37789/diff/
>
>
> Testing
> -------
>
> Relevant benchmark impact is minimal:
>
> Before this change:
> ```
> Benchmark (instances) Mode Cnt Score Error Units
> UpdateStoreBenchmarks.JobDetailsBenchmark.run 1000 thrpt 5 347.863 ± 77.177 ops/s
> UpdateStoreBenchmarks.JobDetailsBenchmark.run 5000 thrpt 5 77.135 ± 13.291 ops/s
> UpdateStoreBenchmarks.JobDetailsBenchmark.run 10000 thrpt 5 37.630 ± 5.200 ops/s
> ```
>
> After this change:
> ```
> Benchmark (instances) Mode Cnt Score Error Units
> UpdateStoreBenchmarks.JobDetailsBenchmark.run 1000 thrpt 5 308.792 ± 159.968 ops/s
> UpdateStoreBenchmarks.JobDetailsBenchmark.run 5000 thrpt 5 71.926 ± 35.703 ops/s
> UpdateStoreBenchmarks.JobDetailsBenchmark.run 10000 thrpt 5 41.472 ± 10.632 ops/s
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37789: Refer to shared task_configs table for job
updates.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37789/
-----------------------------------------------------------
(Updated Aug. 29, 2015, 8:45 a.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-647
https://issues.apache.org/jira/browse/AURORA-647
Repository: aurora
Description
-------
Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there.
Diffs (updated)
-----
src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 48bee5068db5aeacf181c76c4d3add71d045c8a9
src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java fd46c3f0718c7c60b7b80b903545490cd7727204
src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4
src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e
src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5
Diff: https://reviews.apache.org/r/37789/diff/
Testing (updated)
-------
Relevant benchmark impact is minimal:
Before this change:
```
Benchmark (instances) Mode Cnt Score Error Units
UpdateStoreBenchmarks.JobDetailsBenchmark.run 1000 thrpt 5 347.863 ± 77.177 ops/s
UpdateStoreBenchmarks.JobDetailsBenchmark.run 5000 thrpt 5 77.135 ± 13.291 ops/s
UpdateStoreBenchmarks.JobDetailsBenchmark.run 10000 thrpt 5 37.630 ± 5.200 ops/s
```
After this change:
```
Benchmark (instances) Mode Cnt Score Error Units
UpdateStoreBenchmarks.JobDetailsBenchmark.run 1000 thrpt 5 308.792 ± 159.968 ops/s
UpdateStoreBenchmarks.JobDetailsBenchmark.run 5000 thrpt 5 71.926 ± 35.703 ops/s
UpdateStoreBenchmarks.JobDetailsBenchmark.run 10000 thrpt 5 41.472 ± 10.632 ops/s
```
Thanks,
Bill Farner
Re: Review Request 37789: Refer to shared task_configs table for job
updates.
Posted by Bill Farner <wf...@apache.org>.
> On Aug. 26, 2015, 10:38 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java, line 162
> > <https://reviews.apache.org/r/37789/diff/1/?file=1053026#file1053026line162>
> >
> > Inline this method reference.
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37789/#review96558
-----------------------------------------------------------
On Aug. 25, 2015, 11:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37789/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 11:41 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-647
> https://issues.apache.org/jira/browse/AURORA-647
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 7728684560d3111edaa2e29d9738f71bc1d7a9ff
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5
>
> Diff: https://reviews.apache.org/r/37789/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37789: Refer to shared task_configs table for job
updates.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37789/#review96558
-----------------------------------------------------------
Ship it!
Ship It!
src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java (line 160)
<https://reviews.apache.org/r/37789/#comment152067>
Inline this method reference.
- Kevin Sweeney
On Aug. 25, 2015, 11:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37789/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 11:41 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-647
> https://issues.apache.org/jira/browse/AURORA-647
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unfortunately the reference forced me to move the location of tables in schema.sql, making the delta look much bigger there.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 7728684560d3111edaa2e29d9738f71bc1d7a9ff
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 02ea355539d6f56c1c861ac83293b649285f43f4
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java 2f58357dd63c46eb69de6a6daedcf027712d7b2e
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 9afc3f3fcdcc1b60af2207888993411a55984c8e
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 6ffb54f5beef332097fd5c2390b56873a82f0aa9
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql d971aa19982e6095fbf514714df670cabd523d9d
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5
>
> Diff: https://reviews.apache.org/r/37789/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>