You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/12 20:53:26 UTC
[GitHub] reminisce commented on a change in pull request #11641: [MXNET-876]
make CachedOp a normal operator
reminisce commented on a change in pull request #11641: [MXNET-876] make CachedOp a normal operator
URL: https://github.com/apache/incubator-mxnet/pull/11641#discussion_r217185002
##########
File path: src/operator/subgraph/common.h
##########
@@ -94,10 +93,15 @@ inline bool DefaultSubgraphOpShape(const nnvm::NodeAttrs& attrs,
return g.GetAttr<size_t>("shape_num_unknown_nodes") == 0;
}
-inline bool DefaultSubgraphOpType(const nnvm::NodeAttrs& attrs,
- std::vector<int> *in_types,
- std::vector<int> *out_types) {
- const nnvm::Symbol& subgraph_sym = *attrs.subgraphs[0];
+inline bool DefaultSubgraphOpShape(const nnvm::NodeAttrs& attrs,
+ std::vector<TShape> *in_shapes,
+ std::vector<TShape> *out_shapes) {
+ return DefaultSubgraphOpShape1(*attrs.subgraphs[0], in_shapes, out_shapes);
Review comment:
Maybe rename `DefaultSubgraphOpShape1` to something like a helper function for better readability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services