You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/17 23:01:49 UTC

[GitHub] [airflow] dstandish commented on pull request #17934: Add dags.gitSync.sshKeyCustomFile parameter to allow other SSH key sources

dstandish commented on pull request #17934:
URL: https://github.com/apache/airflow/pull/17934#issuecomment-997079775


   > I'm still leaning toward not setting `GIT_SSH_KEY_FILE` at all, since we just set it to the default anyways, which would allow users to use `gitSync.env` to set both it and enable `GIT_SYNC_SSH`. I think that'd be more intuitive than an extra param in our chart.
   
   this  sounds good to me. we can set most of the git-sync sidecar params from env vars and that seems like the most future-proof / hands off / cleanest approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org