You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Qianyi951015 (via GitHub)" <gi...@apache.org> on 2023/02/17 06:20:05 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #24211: Refactor `UnlabelComputeNodeHandler`
Qianyi951015 opened a new pull request, #24211:
URL: https://github.com/apache/shardingsphere/pull/24211
For #24181.
Changes proposed in this pull request:
- Refactor `UnlabelComputeNodeHandler`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24211: Refactor `UnlabelComputeNodeHandler`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24211:
URL: https://github.com/apache/shardingsphere/pull/24211#issuecomment-1434209556
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24211](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd3b674) into [master](https://codecov.io/gh/apache/shardingsphere/commit/747e1cb5917946155170d1dd7f1441cdbfc32376?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (747e1cb) will **increase** coverage by `0.00%`.
> The diff coverage is `38.98%`.
> :exclamation: Current head cd3b674 differs from pull request most recent head f56a03c. Consider uploading reports for the commit f56a03c to get more accurate results
```diff
@@ Coverage Diff @@
## master #24211 +/- ##
=========================================
Coverage 50.12% 50.12%
Complexity 1580 1580
=========================================
Files 3255 3256 +1
Lines 53474 53515 +41
Branches 9856 9870 +14
=========================================
+ Hits 26806 26827 +21
- Misses 24312 24326 +14
- Partials 2356 2362 +6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ngsphere/data/pipeline/cdc/api/impl/CDCJobAPI.java](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2FwaS9pbXBsL0NEQ0pvYkFQSS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ception/NotFindStreamDataSourceTableException.java](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2V4Y2VwdGlvbi9Ob3RGaW5kU3RyZWFtRGF0YVNvdXJjZVRhYmxlRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `66.66% <ø> (-1.20%)` | :arrow_down: |
| [...proxy/frontend/netty/CDCChannelInboundHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvbmV0dHkvQ0RDQ2hhbm5lbEluYm91bmRIYW5kbGVyLmphdmE=) | `25.20% <ø> (ø)` | |
| [...stsql/ral/updatable/UnlabelComputeNodeUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9VbmxhYmVsQ29tcHV0ZU5vZGVVcGRhdGVyLmphdmE=) | `26.66% <28.57%> (ø)` | |
| [...e/proxy/backend/handler/cdc/CDCBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2NkYy9DRENCYWNrZW5kSGFuZGxlci5qYXZh) | `24.73% <40.00%> (+15.64%)` | :arrow_up: |
| [.../core/importer/connector/CDCImporterConnector.java](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvaW1wb3J0ZXIvY29ubmVjdG9yL0NEQ0ltcG9ydGVyQ29ubmVjdG9yLmphdmE=) | `15.55% <100.00%> (ø)` | |
| [...ingsphere/data/pipeline/cdc/core/job/CDCJobId.java](https://codecov.io/gh/apache/shardingsphere/pull/24211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvam9iL0NEQ0pvYklkLmphdmE=) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24211: Refactor `UnlabelComputeNodeHandler`
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24211:
URL: https://github.com/apache/shardingsphere/pull/24211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org