You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2024/11/05 00:12:10 UTC
(pinot) branch master updated: Check for peerSegmentDownloadScheme when reaching out to peer servers for segment (#14378)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 57ecbb946c Check for peerSegmentDownloadScheme when reaching out to peer servers for segment (#14378)
57ecbb946c is described below
commit 57ecbb946ca4fdb4cd2836565e496626cf695390
Author: ilamhs <ik...@hubspot.com>
AuthorDate: Mon Nov 4 16:12:04 2024 -0800
Check for peerSegmentDownloadScheme when reaching out to peer servers for segment (#14378)
---
.../helix/core/realtime/PinotLLCRealtimeSegmentManager.java | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
index 91e4bdab2e..406c405b42 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
@@ -1539,9 +1539,15 @@ public class PinotLLCRealtimeSegmentManager {
try {
LOGGER.info("Fixing LLC segment {} whose deep store copy is unavailable", segmentName);
// Find servers which have online replica
+
+ String peerSegmentDownloadScheme = validationConfig.getPeerSegmentDownloadScheme();
+ if (peerSegmentDownloadScheme == null) {
+ peerSegmentDownloadScheme = CommonConstants.HTTP_PROTOCOL;
+ }
+
List<URI> peerSegmentURIs =
PeerServerSegmentFinder.getPeerServerURIs(_helixManager, realtimeTableName, segmentName,
- CommonConstants.HTTP_PROTOCOL);
+ peerSegmentDownloadScheme);
if (peerSegmentURIs.isEmpty()) {
throw new IllegalStateException(
String.format("Failed to upload segment %s to deep store because no online replica is found",
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org