[PR] [FLINK-40604][datastream] Route expired async retry results through timeout handler [flink]

["dpeacock (via GitHub)" <gi...@apache.org>]

dpeacock opened a new pull request, #29327:
URL: https://github.com/apache/flink/pull/29327

   ## What is the purpose of the change
   
   Fixes [FLINK-40604](https://issues.apache.org/jira/browse/FLINK-40604).
   
   An async attempt can finish before the overall timeout but have its retry-result mail processed after the deadline and before the timer callback. In that ordering, `AsyncWaitOperator` handles the stale attempt as a normal result, which can bypass the configured timeout handler and fail the task.
   
   This change makes the overall timeout authoritative regardless of mailbox and timer callback ordering.
   
   ## Brief change log
   
   - Route retry results processed after the overall deadline through the existing timeout handler.
   - Make timeout handling one-shot when retry-result and timer callbacks race.
   - Propagate exceptions raised by the timeout handler from mailbox processing.
   
   ## Verifying this change
   
   Added deterministic `AsyncWaitOperatorTest` coverage for:
   
   - Successful and exceptional attempt results processed after the deadline.
   - The exact timeout boundary.
   - Both retry-result/timer callback orderings.
   - Timeout-handler exception propagation.
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): yes
   - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
   - The S3 file system connector: no
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tools below)
   
   Generated-by: Codex (GPT-5)
   Generated-by: Claudex (GPT-5.4)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40604][datastream] Route expired async retry results through timeout handler [flink]

["dpeacock (via GitHub)" <gi...@apache.org>]

dpeacock commented on PR #29327:
URL: https://github.com/apache/flink/pull/29327#issuecomment-6374010044

   cc/ @snuyanzin & @lincoln-lil as I think you've made related changes recently in this area.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40604][datastream] Route expired async retry results through timeout handler [flink]

["flinkbot (via GitHub)" <gi...@apache.org>]

flinkbot commented on PR #29327:
URL: https://github.com/apache/flink/pull/29327#issuecomment-5874468430

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ae412505de006c36815bd741fa047c8941010dc1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ae412505de006c36815bd741fa047c8941010dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ae412505de006c36815bd741fa047c8941010dc1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org