You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/21 07:16:15 UTC
[GitHub] [ozone] kaijchen opened a new pull request #3117: HDDS-6354. EC: Fix allocateBlockIfFull condition in ECKeyOutputStream#write()
kaijchen opened a new pull request #3117:
URL: https://github.com/apache/ozone/pull/3117
## What changes were proposed in this pull request?
`remLen > 0` will always be true if `iters > 0`.
I think it's intended to be `lastCellSize > 0`.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6354
## How was this patch tested?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3117: HDDS-6354. EC: Fix allocateBlockIfFull condition in ECKeyOutputStream#write()
Posted by GitBox <gi...@apache.org>.
kaijchen commented on pull request #3117:
URL: https://github.com/apache/ozone/pull/3117#issuecomment-1047463048
This patch won't be needed if HDDS-6358(#3120) gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3117: HDDS-6354. EC: Fix allocateBlockIfFull condition in ECKeyOutputStream#write()
Posted by GitBox <gi...@apache.org>.
kaijchen commented on pull request #3117:
URL: https://github.com/apache/ozone/pull/3117#issuecomment-1050444419
Closed because of https://github.com/apache/ozone/pull/3120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on pull request #3117: HDDS-6354. EC: Fix allocateBlockIfFull condition in ECKeyOutputStream#write()
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on pull request #3117:
URL: https://github.com/apache/ozone/pull/3117#issuecomment-1048056314
Thanks @kaijchen for reporting and @guihecheng for the initial review.
Here is my suggestion: Let's review the refactor JIRA first as that will supersede this issue anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #3117: HDDS-6354. EC: Fix allocateBlockIfFull condition in ECKeyOutputStream#write()
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #3117:
URL: https://github.com/apache/ozone/pull/3117#discussion_r810937747
##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -184,7 +184,7 @@ public void write(byte[] b, int off, int len) throws IOException {
pos = handleDataWrite(currentStreamIdx, b, off, ecChunkSize, true);
off += ecChunkSize;
iters--;
- checkAndWriteParityCells(pos, iters > 0 || remLen > 0);
+ checkAndWriteParityCells(pos, iters > 0 || lastCellSize > 0);
Review comment:
This should be a good catch.
LGTM+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen closed pull request #3117: HDDS-6354. EC: Fix allocateBlockIfFull condition in ECKeyOutputStream#write()
Posted by GitBox <gi...@apache.org>.
kaijchen closed pull request #3117:
URL: https://github.com/apache/ozone/pull/3117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org