You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by fu...@apache.org on 2005/07/27 21:19:59 UTC
svn commit: r225581 - in /incubator/derby/code/trunk: BUILDING.txt build.xml
Author: fuzzylogic
Date: Wed Jul 27 12:19:58 2005
New Revision: 225581
URL: http://svn.apache.org/viewcvs?rev=225581&view=rev
Log:
Fix a problem building with -Dsane=false. The ensuresanitystate target
would cause sanity to be set to true even though sane=false and the correct
SanityState.java and state.properties were generated. Also update BUILDING.txt
to remove the mention of the property 'sanity' which should only be set from
state.properties.
Modified:
incubator/derby/code/trunk/BUILDING.txt
incubator/derby/code/trunk/build.xml
Modified: incubator/derby/code/trunk/BUILDING.txt
URL: http://svn.apache.org/viewcvs/incubator/derby/code/trunk/BUILDING.txt?rev=225581&r1=225580&r2=225581&view=diff
==============================================================================
--- incubator/derby/code/trunk/BUILDING.txt (original)
+++ incubator/derby/code/trunk/BUILDING.txt Wed Jul 27 12:19:58 2005
@@ -609,11 +609,10 @@
is then generated from a template. The sanity state defaults to
true. This also directs the compiler to turn on all debugging
options on the compiler. The sanity state can be set to insane
-by running 'ant insane' or passing in the value -Dsane=false or
--Dsanity=false. Note that this file will be removed after
-'ant clobber,' so if you are rebuilding from scratch and want
-the build to be a non-debug build, run 'ant insane' before
-building.
+by running 'ant insane' or passing in the value -Dsane=false.
+Note that this file will be removed after 'ant clobber,' so if
+you are rebuilding from scratch and want the build to be a
+non-debug build, run 'ant insane' before building.
Once the sanity state has been generated, Ant prints out for
reference the current properties that affect the build,
Modified: incubator/derby/code/trunk/build.xml
URL: http://svn.apache.org/viewcvs/incubator/derby/code/trunk/build.xml?rev=225581&r1=225580&r2=225581&view=diff
==============================================================================
--- incubator/derby/code/trunk/build.xml (original)
+++ incubator/derby/code/trunk/build.xml Wed Jul 27 12:19:58 2005
@@ -47,8 +47,21 @@
</target>
<target name="ensuresanitystate" unless="state.available">
+ <antcall target="evaluate.sane"/>
+ <antcall target="ensuresanitystate.sane"/>
+ <antcall target="ensuresanitystate.insane"/>
+ </target>
+ <target name="evaluate.sane">
+ <condition property="generate.sane">
+ <equals arg1="${sane}" arg2="true"/>
+ </condition>
+ </target>
+ <target name="ensuresanitystate.sane" if="generate.sane">
<antcall target="sane"/>
</target>
+ <target name="ensuresanitystate.insane" unless="generate.sane">
+ <antcall target="insane"/>
+ </target>
<target name="showenv" depends="init" unless="showenv.done">
<echo message=""/>
@@ -482,11 +495,15 @@
<propertyfile file="${state.file}" comment="${header}">
<entry key="sanity" value="true" type="string"/>
</propertyfile>
+ <delete file="${sanity.dir}/SanityState.java"/>
+ <delete dir="${sanity.out.dir}"/>
</target>
<target name="insane">
<propertyfile file="${state.file}" comment="${header}">
<entry key="sanity" value="false" type="string"/>
</propertyfile>
+ <delete file="${sanity.dir}/SanityState.java"/>
+ <delete dir="${sanity.out.dir}"/>
</target>
Re: svn commit: r225581 - in /incubator/derby/code/trunk: BUILDING.txt build.xml
Posted by Andrew McIntyre <mc...@gmail.com>.
On Jul 27, 2005, at 2:20 PM, scott hutinger wrote:
> Shouldn't the non-debug be 'ant sane' and the debug build be 'ant
> insane' .
> Possibly a debug build and non-debug build run commands should both
> be used. (If I read it
> wrong, then I am confused, and possibly others will be also (maybe
> not) ) :-)
From BUILDING.txt:
'Sanity' was a concept introduced early in Cloudscape as a way of
having assert functionality
in the code before Java actually supported such functionality
syntactically. It was a way to keep development 'sane,' thus the name.
:-)
andrew
Re: svn commit: r225581 - in /incubator/derby/code/trunk: BUILDING.txt
build.xml
Posted by scott hutinger <s-...@wiu.edu>.
scott hutinger wrote:
> fuzzylogic@apache.org wrote:
>
>> Author: fuzzylogic
>> Date: Wed Jul 27 12:19:58 2005
>> New Revision: 225581
>>
>> URL: http://svn.apache.org/viewcvs?rev=225581&view=rev
>> Log:
>> Fix a problem building with -Dsane=false. The ensuresanitystate target
>> would cause sanity to be set to true even though sane=false and the
>> correct
>> SanityState.java and state.properties were generated. Also update
>> BUILDING.txt
>> to remove the mention of the property 'sanity' which should only be
>> set from
>> state.properties.
>>
>> Modified:
>> incubator/derby/code/trunk/BUILDING.txt
>> incubator/derby/code/trunk/build.xml
>>
>> Modified: incubator/derby/code/trunk/BUILDING.txt
>> URL:
>> http://svn.apache.org/viewcvs/incubator/derby/code/trunk/BUILDING.txt?rev=225581&r1=225580&r2=225581&view=diff
>>
>> ==============================================================================
>>
>> --- incubator/derby/code/trunk/BUILDING.txt (original)
>> +++ incubator/derby/code/trunk/BUILDING.txt Wed Jul 27 12:19:58 2005
>> @@ -609,11 +609,10 @@
>> is then generated from a template. The sanity state defaults to true.
>> This also directs the compiler to turn on all debugging options on
>> the compiler. The sanity state can be set to insane -by running 'ant
>> insane' or passing in the value -Dsane=false or --Dsanity=false. Note
>> that this file will be removed after -'ant clobber,' so if you are
>> rebuilding from scratch and want -the build to be a non-debug build,
>> run 'ant insane' before -building.
>> +by running 'ant insane' or passing in the value -Dsane=false.
>> +Note that this file will be removed after 'ant clobber,' so if
>> +you are rebuilding from scratch and want the build to be a
>> +non-debug build, run 'ant insane' before building.
>>
>>
I thought I should clarify my confusion, which is related to sane, insane.
In building a JVM, sanity is used to say, sane=check my jvm build
version to build the vm. insane = I don't have that JVM up yet, so let
me do what I want. So to me, insane is not the norm, nor do I think -g
is the norm. I think most sane users people (the wording only) would
use non-debug, and non-normal would use the -g version of derby.
But, as a developer, sane would be debug; in most instances.
Hmm, now I really am confused.
scott
> Shouldn't the non-debug be 'ant sane' and the debug build be 'ant
> insane' .
> Possibly a debug build and non-debug build run commands should both be
> used. (If I read it
> wrong, then I am confused, and possibly others will be also (maybe
> not) ) :-)
>
> thanks,
> scott
>
>>
>> Once the sanity state has been generated, Ant prints out for
>> reference the current properties that affect the build,
>> Modified: incubator/derby/code/trunk/build.xml
>> URL:
>> http://svn.apache.org/viewcvs/incubator/derby/code/trunk/build.xml?rev=225581&r1=225580&r2=225581&view=diff
>>
>> ==============================================================================
>>
>> --- incubator/derby/code/trunk/build.xml (original)
>> +++ incubator/derby/code/trunk/build.xml Wed Jul 27 12:19:58 2005
>> @@ -47,8 +47,21 @@
>> </target>
>>
>> <target name="ensuresanitystate" unless="state.available">
>> + <antcall target="evaluate.sane"/>
>> + <antcall target="ensuresanitystate.sane"/>
>> + <antcall target="ensuresanitystate.insane"/>
>> + </target>
>> + <target name="evaluate.sane">
>> + <condition property="generate.sane">
>> + <equals arg1="${sane}" arg2="true"/>
>> + </condition>
>> + </target>
>> + <target name="ensuresanitystate.sane" if="generate.sane">
>> <antcall target="sane"/>
>> </target>
>> + <target name="ensuresanitystate.insane" unless="generate.sane">
>> + <antcall target="insane"/>
>> + </target>
>>
>> <target name="showenv" depends="init" unless="showenv.done">
>> <echo message=""/>
>> @@ -482,11 +495,15 @@
>> <propertyfile file="${state.file}" comment="${header}">
>> <entry key="sanity" value="true" type="string"/>
>> </propertyfile>
>> + <delete file="${sanity.dir}/SanityState.java"/>
>> + <delete dir="${sanity.out.dir}"/>
>> </target>
>> <target name="insane">
>> <propertyfile file="${state.file}" comment="${header}">
>> <entry key="sanity" value="false" type="string"/>
>> </propertyfile>
>> + <delete file="${sanity.dir}/SanityState.java"/>
>> + <delete dir="${sanity.out.dir}"/>
>> </target>
>>
>>
>>
>>
>>
>>
>
Re: svn commit: r225581 - in /incubator/derby/code/trunk: BUILDING.txt
build.xml
Posted by scott hutinger <s-...@wiu.edu>.
fuzzylogic@apache.org wrote:
>Author: fuzzylogic
>Date: Wed Jul 27 12:19:58 2005
>New Revision: 225581
>
>URL: http://svn.apache.org/viewcvs?rev=225581&view=rev
>Log:
>Fix a problem building with -Dsane=false. The ensuresanitystate target
>would cause sanity to be set to true even though sane=false and the correct
>SanityState.java and state.properties were generated. Also update BUILDING.txt
>to remove the mention of the property 'sanity' which should only be set from
>state.properties.
>
>Modified:
> incubator/derby/code/trunk/BUILDING.txt
> incubator/derby/code/trunk/build.xml
>
>Modified: incubator/derby/code/trunk/BUILDING.txt
>URL: http://svn.apache.org/viewcvs/incubator/derby/code/trunk/BUILDING.txt?rev=225581&r1=225580&r2=225581&view=diff
>==============================================================================
>--- incubator/derby/code/trunk/BUILDING.txt (original)
>+++ incubator/derby/code/trunk/BUILDING.txt Wed Jul 27 12:19:58 2005
>@@ -609,11 +609,10 @@
> is then generated from a template. The sanity state defaults to
> true. This also directs the compiler to turn on all debugging
> options on the compiler. The sanity state can be set to insane
>-by running 'ant insane' or passing in the value -Dsane=false or
>--Dsanity=false. Note that this file will be removed after
>-'ant clobber,' so if you are rebuilding from scratch and want
>-the build to be a non-debug build, run 'ant insane' before
>-building.
>+by running 'ant insane' or passing in the value -Dsane=false.
>+Note that this file will be removed after 'ant clobber,' so if
>+you are rebuilding from scratch and want the build to be a
>+non-debug build, run 'ant insane' before building.
>
>
Shouldn't the non-debug be 'ant sane' and the debug build be 'ant insane' .
Possibly a debug build and non-debug build run commands should both be
used. (If I read it
wrong, then I am confused, and possibly others will be also (maybe not)
) :-)
thanks,
scott
>
> Once the sanity state has been generated, Ant prints out for
> reference the current properties that affect the build,
>
>Modified: incubator/derby/code/trunk/build.xml
>URL: http://svn.apache.org/viewcvs/incubator/derby/code/trunk/build.xml?rev=225581&r1=225580&r2=225581&view=diff
>==============================================================================
>--- incubator/derby/code/trunk/build.xml (original)
>+++ incubator/derby/code/trunk/build.xml Wed Jul 27 12:19:58 2005
>@@ -47,8 +47,21 @@
> </target>
>
> <target name="ensuresanitystate" unless="state.available">
>+ <antcall target="evaluate.sane"/>
>+ <antcall target="ensuresanitystate.sane"/>
>+ <antcall target="ensuresanitystate.insane"/>
>+ </target>
>+ <target name="evaluate.sane">
>+ <condition property="generate.sane">
>+ <equals arg1="${sane}" arg2="true"/>
>+ </condition>
>+ </target>
>+ <target name="ensuresanitystate.sane" if="generate.sane">
> <antcall target="sane"/>
> </target>
>+ <target name="ensuresanitystate.insane" unless="generate.sane">
>+ <antcall target="insane"/>
>+ </target>
>
> <target name="showenv" depends="init" unless="showenv.done">
> <echo message=""/>
>@@ -482,11 +495,15 @@
> <propertyfile file="${state.file}" comment="${header}">
> <entry key="sanity" value="true" type="string"/>
> </propertyfile>
>+ <delete file="${sanity.dir}/SanityState.java"/>
>+ <delete dir="${sanity.out.dir}"/>
> </target>
> <target name="insane">
> <propertyfile file="${state.file}" comment="${header}">
> <entry key="sanity" value="false" type="string"/>
> </propertyfile>
>+ <delete file="${sanity.dir}/SanityState.java"/>
>+ <delete dir="${sanity.out.dir}"/>
> </target>
>
>
>
>
>
>