You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/22 03:56:41 UTC

[GitHub] [apisix] SkyeYoung commented on a diff in pull request #6881: fixed plugin concept link in README

SkyeYoung commented on code in PR #6881:
URL: https://github.com/apache/apisix/pull/6881#discussion_r855747183


##########
README.md:
##########
@@ -184,7 +184,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
 4. Plugin development
 
    You can refer to [plugin development guide](docs/en/latest/plugin-develop.md), and sample plugin `example-plugin`'s code implementation.
-   Reading [plugin concept](docs/en/latest/architecture-design/plugin.md) would help you learn more about the plugin.
+   Reading [plugin concept](docs/en/latest/architecture-design/apisix.md) would help you learn more about the plugin.

Review Comment:
   > I did not realise that this was a change in README. For this case, a linter in GitHub workflows should work. There should be some action available that we can use.
   > 
   > For APISIX documentation, we have multiple repos and documentation for each of the components are in different repos. This is pulled in the apisix-website repo during a build. So, pages could be linked across repos and I don't think we can have static lint checks to catch them. We may need to build the website and test the links from the built website using some workflow.
   
   @navendu-pottekkat  We already have one, pls see https://github.com/apache/apisix-website/issues/1047.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org