You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/10 01:08:43 UTC
[GitHub] [phoenix-queryserver] joshelser opened a new pull request #43: PHOENIX-5999 Hack together a better implementation for executemany us…
joshelser opened a new pull request #43:
URL: https://github.com/apache/phoenix-queryserver/pull/43
…ing ExecuteBatch
Need to get tests updated too and make sure this is adapted to sqlalchemy bindings as well, but sharing now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty commented on pull request #43: PHOENIX-5999 Hack together a better implementation for executemany us…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #43:
URL: https://github.com/apache/phoenix-queryserver/pull/43#issuecomment-660686471
We already have executemany() tests from dbapi20.py, so that angle is covered as well.
The only changes that I've made is updating the exception message (and all remaining exception messages) to be full sentences, as you suggested in a previous review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] asfgit closed pull request #43: PHOENIX-5999 Hack together a better implementation for executemany us…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #43:
URL: https://github.com/apache/phoenix-queryserver/pull/43
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty commented on pull request #43: PHOENIX-5999 Hack together a better implementation for executemany us…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #43:
URL: https://github.com/apache/phoenix-queryserver/pull/43#issuecomment-657954077
Looks good. (but I agree that needs a test)
Actually, I don't think we need (or indeed can) do anything in the SqlAlchemy driver for this, this seems to be handled in SqlAlchemy core.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] joshelser commented on pull request #43: PHOENIX-5999 Hack together a better implementation for executemany us…
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #43:
URL: https://github.com/apache/phoenix-queryserver/pull/43#issuecomment-662187805
Thanks Istvan!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org