You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2017/04/06 08:29:38 UTC
[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/2030
WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack snapshot-housekeeping
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/2030.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2030
----
commit 40869570fc510fac0d2357f272e96cd4a4518176
Author: Daan Hoogland <da...@shapeblue.com>
Date: 2017-03-30T14:35:37Z
CE-113 trace logging and rethrow instead of nesting CloudRuntimeException
commit 66d7d846352d52cc539b1dafb5e4d0f1620829a5
Author: Daan Hoogland <da...@shapeblue.com>
Date: 2017-04-05T12:19:14Z
CE-113 configure workervm gc based on job expiry
commit 996f5834e6a0a9e4dc57d436ceeb5b89e6dc9974
Author: Daan Hoogland <da...@shapeblue.com>
Date: 2017-04-05T15:35:41Z
CE-113 extra trace log of worker VMs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2030
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/2030
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2030
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-624
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2030
show me the money (tm)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2030
@blueorangutan test centos7 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2030
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2030
renaming and close-opening for retests. "it works on my laptop (tm)"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2030
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-632
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2030
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2030#discussion_r110145761
--- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java ---
@@ -128,6 +129,7 @@
public class VmwareManagerImpl extends ManagerBase implements VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService, Configurable {
private static final Logger s_logger = Logger.getLogger(VmwareManagerImpl.class);
+ private static final long MILISECONDS_PER_MINUTE = 60000;
--- End diff --
MILI typo MILLISECONDS ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2030
<b>Trillian test result (tid-983)</b>
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51519 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2030-t983-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 48 look ok, 2 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_test_vm_volume_snapshot | `Failure` | 322.23 | test_vm_snapshots.py
test_04_rvpc_privategw_static_routes | `Failure` | 888.45 | test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 371.71 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 166.99 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 593.09 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 354.29 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 742.66 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 675.76 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1534.04 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 751.75 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 704.82 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1374.94 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 30.73 | test_volumes.py
test_06_download_detached_volume | Success | 60.53 | test_volumes.py
test_05_detach_volume | Success | 105.26 | test_volumes.py
test_04_delete_attached_volume | Success | 10.18 | test_volumes.py
test_03_download_attached_volume | Success | 20.32 | test_volumes.py
test_02_attach_volume | Success | 58.72 | test_volumes.py
test_01_create_volume | Success | 519.39 | test_volumes.py
test_change_service_offering_for_vm_with_snapshots | Success | 548.99 | test_vm_snapshots.py
test_03_delete_vm_snapshots | Success | 275.23 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 232.04 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.65 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 242.48 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.83 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 60.94 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.14 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.13 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.25 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.14 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 206.29 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 10.20 | test_templates.py
test_03_delete_template | Success | 5.09 | test_templates.py
test_02_edit_template | Success | 90.13 | test_templates.py
test_01_create_template | Success | 121.06 | test_templates.py
test_10_destroy_cpvm | Success | 266.87 | test_ssvm.py
test_09_destroy_ssvm | Success | 268.71 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.52 | test_ssvm.py
test_07_reboot_ssvm | Success | 188.45 | test_ssvm.py
test_06_stop_cpvm | Success | 176.88 | test_ssvm.py
test_05_stop_ssvm | Success | 203.78 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 3.39 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
test_02_list_snapshots_with_removed_data_store | Success | 167.39 | test_snapshots.py
test_01_snapshot_root_disk | Success | 26.23 | test_snapshots.py
test_04_change_offering_small | Success | 97.22 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py
test_09_reboot_router | Success | 130.80 | test_routers.py
test_08_start_router | Success | 120.73 | test_routers.py
test_07_stop_router | Success | 20.19 | test_routers.py
test_06_router_advanced | Success | 0.05 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.65 | test_routers.py
test_03_restart_network_cleanup | Success | 135.86 | test_routers.py
test_02_router_internal_adv | Success | 1.06 | test_routers.py
test_01_router_internal_basic | Success | 0.52 | test_routers.py
test_router_dns_guestipquery | Success | 76.67 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.08 | test_router_dns.py
test_router_dhcphosts | Success | 138.74 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.62 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.10 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 60.48 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.20 | test_regions.py
test_create_pvlan_network | Success | 5.21 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.46 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 1093.23 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 621.34 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 182.83 | test_privategw_acl.py
test_03_migration_options_storage_tags | Success | 37.29 | test_primary_storage.py
test_02_edit_primary_storage_tags | Success | 0.09 | test_primary_storage.py
test_01_primary_storage_nfs | Success | 36.28 | test_primary_storage.py
test_01_deploy_vms_storage_tags | Success | 51.43 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.19 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.44 | test_portable_publicip.py
test_isolate_network_password_server | Success | 92.15 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.12 | test_over_provisioning.py
test_oobm_zchange_password | Success | 25.65 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.34 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.26 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.33 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.29 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.40 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.29 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.32 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 92.61 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.15 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 5.25 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.09 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.07 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.07 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 29.45 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.29 | test_non_contigiousvlan.py
test_01_nic | Success | 434.61 | test_nic.py
test_releaseIP | Success | 278.04 | test_network.py
test_reboot_router | Success | 640.49 | test_network.py
test_public_ip_user_account | Success | 10.28 | test_network.py
test_public_ip_admin_account | Success | 40.27 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 76.77 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.63 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.71 | test_network.py
test_delete_account | Success | 272.76 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.62 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.75 | test_network.py
test_nested_virtualization_vmware | Success | 328.96 | test_nested_virtualization.py
test_nic_secondaryip_add_remove | Success | 192.40 | test_multipleips_per_nic.py
test_list_zones_metrics | Success | 0.22 | test_metrics_api.py
test_list_volumes_metrics | Success | 5.48 | test_metrics_api.py
test_list_vms_metrics | Success | 191.87 | test_metrics_api.py
test_list_pstorage_metrics | Success | 0.26 | test_metrics_api.py
test_list_infrastructure_metrics | Success | 0.50 | test_metrics_api.py
test_list_hosts_metrics | Success | 0.30 | test_metrics_api.py
test_list_clusters_metrics | Success | 0.43 | test_metrics_api.py
login_test_saml_user | Success | 19.17 | test_login.py
test_assign_and_removal_lb | Success | 148.27 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 207.22 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 207.70 | test_loadbalance.py
test_03_list_snapshots | Success | 0.10 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.26 | test_iso.py
test_03_delete_iso | Success | 95.23 | test_iso.py
test_02_edit_iso | Success | 0.09 | test_iso.py
test_01_create_iso | Success | 21.01 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 510.11 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 395.80 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 1003.02 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 823.20 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.26 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 6.22 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 5.96 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 5.84 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 5.92 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 5.99 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 5.89 | test_dynamicroles.py
test_role_lifecycle_update | Success | 10.96 | test_dynamicroles.py
test_role_lifecycle_list | Success | 5.94 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 10.91 | test_dynamicroles.py
test_role_lifecycle_create | Success | 6.00 | test_dynamicroles.py
test_role_inuse_deletion | Success | 5.89 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 8.27 | test_dynamicroles.py
test_role_account_acls | Success | 8.59 | test_dynamicroles.py
test_default_role_deletion | Success | 5.99 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.07 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 60.95 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 91.74 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 171.81 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 75.93 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 161.36 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 5.84 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 5.83 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 6.53 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 222.89 | test_deploy_vm_iso.py
test_3d_gpu_support | Success | 475.24 | test_deploy_vgpu_enabled_vm.py
test_DeployVmAntiAffinityGroup | Success | 201.78 | test_affinity_groups.py
test_08_resize_volume | Skipped | 5.10 | test_volumes.py
test_07_resize_fail | Skipped | 10.26 | test_volumes.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
test_01_scale_vm | Skipped | 66.32 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 1.06 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2030#discussion_r110145877
--- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java ---
@@ -550,15 +552,21 @@ public boolean needRecycle(String workerTag) {
return true;
}
- // disable time-out check until we have found out a VMware API that can check if
- // there are pending tasks on the subject VM
- /*
- if(System.currentTimeMillis() - startTick > _hungWorkerTimeout) {
- if(s_logger.isInfoEnabled())
- s_logger.info("Worker VM expired, seconds elapsed: " + (System.currentTimeMillis() - startTick) / 1000);
- return true;
- }
- */
+ // this time-out check was disabled
+ // "until we have found out a VMware API that can check if there are pending tasks on the subject VM"
+ // but as we expire jobs and those stale worker VMs stay around untill an MS reboot we opt in to have them removed anyway
+ Long hungWorkerTimeout = 2 * (AsyncJobManagerImpl.JobExpireMinutes.value() + AsyncJobManagerImpl.JobCancelThresholdMinutes.value()) * MILISECONDS_PER_MINUTE;
+ Long letsSayNow = System.currentTimeMillis();
+ if(s_vmwareCleanOldWorderVMs.value() && letsSayNow - startTick > hungWorkerTimeout) {
+ if(s_logger.isInfoEnabled()) {
+ s_logger.info("Worker VM expired, seconds elapsed: " + (System.currentTimeMillis() - startTick) / 1000);
+ }
--- End diff --
For timeouts you may want to use java Duration, that is much cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2030
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2030
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...
Posted by DaanHoogland <gi...@git.apache.org>.
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/2030
WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack snapshot-housekeeping
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/2030.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2030
----
commit 40869570fc510fac0d2357f272e96cd4a4518176
Author: Daan Hoogland <da...@shapeblue.com>
Date: 2017-03-30T14:35:37Z
CE-113 trace logging and rethrow instead of nesting CloudRuntimeException
commit 66d7d846352d52cc539b1dafb5e4d0f1620829a5
Author: Daan Hoogland <da...@shapeblue.com>
Date: 2017-04-05T12:19:14Z
CE-113 configure workervm gc based on job expiry
commit 996f5834e6a0a9e4dc57d436ceeb5b89e6dc9974
Author: Daan Hoogland <da...@shapeblue.com>
Date: 2017-04-05T15:35:41Z
CE-113 extra trace log of worker VMs
commit 9a8ea7c0d1c9775ad7e4200db2b3eca93e121909
Author: Daan Hoogland <da...@shapeblue.com>
Date: 2017-04-06T09:33:53Z
CE-113 removed TODOs
commit e2c0f09609b48f4539f13edcc742ca7e06f0cca2
Author: Daan Hoogland <da...@shapeblue.com>
Date: 2017-04-07T12:54:19Z
CE-113 use of duration (instead of the old clock-tick-based code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---