You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2017/08/21 15:43:08 UTC
[GitHub] activemq-artemis pull request #1478: ARTEMIS-1357 TypedProperties encode/dec...
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1478
ARTEMIS-1357 TypedProperties encode/decode improvement
Several improvements are made on the encode/decode paths:
- fixed load factor on properties to avoid resizing/rehashing and reduce GC pressure
- cached BooleanValue/NullValue instances to reduce GC pressure
- used internal iteration throught lamda while encoding properties to reduce GC pressure and allows loop unrolling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis improve_typed_properties_decode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1478.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1478
----
commit 5c386a857206c3bf3b19909c33f9c670ec7ded80
Author: Francesco Nigro <ni...@gmail.com>
Date: 2017-08-21T14:29:22Z
ARTEMIS-1357 TypedProperties encode/decode improvement
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1478: ARTEMIS-1357 TypedProperties encode/decode imp...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1478
@clebertsuconic Yep, but I'm sure that similar optimizations (if not already present) could be added on the other protocols too...or there is not worth to improve it further?
I'm found these while testing other PRs I've done...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1478: ARTEMIS-1357 TypedProperties encode/decode imp...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1478
@tabish121 @clebertsuconic I need to run the full test suite, but it seems a change with no colleteral effects.
I've a couple of graphs showing the impact of the change:
MASTER:
AFTER THE CHANGE:
While now no resize() method is called at all, and the relative weight of most calls in the decode path are simply disappeared.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1478: ARTEMIS-1357 TypedProperties encode/decode imp...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1478
@clebertsuconic Please do not merge it, I've an additional thing to add on it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1478: ARTEMIS-1357 TypedProperties encode/decode imp...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1478
You know you will make core even faster with this right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1478: ARTEMIS-1357 TypedProperties encode/decode imp...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1478
Nice one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1478: ARTEMIS-1357 TypedProperties encode/dec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1478
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1478: ARTEMIS-1357 TypedProperties encode/decode imp...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1478
Nice! Looks like a reasonable change to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---