You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@guacamole.apache.org by Suat Toksöz <st...@gmail.com> on 2022/05/31 14:12:41 UTC
Apache Guacamole html page edit
Hi,
I would like to edit apache guacamole admin web site, where I can find the
html tags?
--
Best regards,
*Suat Toksöz*
Re: Apache Guacamole html page edit
Posted by Suat Toksöz <st...@gmail.com>.
I just use the apache guacamole extension
(guacamole-client-master/doc/guacamole-branding-example) for the html edit.
Is this format ok, I am missing anything?
here is the html replace code:
*<meta name="replace" content=".settings.section.sessions">*
*<div class="welcome" *ng-class="{loading: !isLoaded()}">
<!-- User Session management -->
<p>{{'SETTINGS_SESSIONS.HELP_SESSIONS' | translate}}</p>
<!-- Form action buttons -->
<div class="action-buttons">
<button class="delete-sessions danger"
ng-disabled="!canDeleteSessions()"
ng-click="deleteSessions()">{{'SETTINGS_SESSIONS.ACTION_DELETE' |
translate}}</button>
</div>
<!-- Session filter -->
<guac-filter filtered-items="filteredWrappers" items="wrappers"
placeholder="'SETTINGS_SESSIONS.FIELD_PLACEHOLDER_FILTER'
| translate"
properties="filteredWrapperProperties"></guac-filter>
<!-- List of current user sessions -->
<table class="sorted session-list">
<thead>
<tr>
<th class="select-session"></th>
<th guac-sort-order="wrapperOrder"
guac-sort-property="'activeConnection.username'">
{{'SETTINGS_SESSIONS.TABLE_HEADER_SESSION_USERNAME' |
translate}}
</th>
<th guac-sort-order="wrapperOrder"
guac-sort-property="'startDate'">
{{'SETTINGS_SESSIONS.TABLE_HEADER_SESSION_STARTDATE' |
translate}}
</th>
<th guac-sort-order="wrapperOrder"
guac-sort-property="'activeConnection.remoteHost'">
{{'SETTINGS_SESSIONS.TABLE_HEADER_SESSION_REMOTEHOST' |
translate}}
</th>
<th guac-sort-order="wrapperOrder"
guac-sort-property="'name'">
{{'SETTINGS_SESSIONS.TABLE_HEADER_SESSION_CONNECTION_NAME' | translate}}
</th>
</tr>
</thead>
<tbody>
<tr ng-repeat="wrapper in wrapperPage" class="session">
<td class="select-session">
<input ng-change="wrapperSelectionChange(wrapper)"
type="checkbox" ng-model="wrapper.checked">
</td>
<td><guac-user-item
username="wrapper.activeConnection.username"></guac-user-item></td>
<td>{{wrapper.startDate}}</td>
<td>{{wrapper.activeConnection.remoteHost}}</td>
*<td><a ng-href="#">{{wrapper.name
<http://wrapper.name>}}</a></td>*
</tr>
</tbody>
</table>
On Wed, Jun 1, 2022 at 8:41 PM Suat Toksöz <st...@gmail.com> wrote:
> Thanks Nick,
>
> Then how can I modify the apache guacamole client , so no one can access
> to active session link from outside.
>
> On 1 Jun 2022, at 20:34, Nick Couchman <vn...@apache.org> wrote:
>
>
> On Wed, Jun 1, 2022 at 12:54 PM Suat Toksöz <st...@gmail.com> wrote:
>
>> So, what is your suggestion for me to edit admin active session tab?
>>
>>
> Creating a custom extension and using the HTML replace functionality is
> the best way to make sure that your changes are future-proof - the base of
> Guacamole Client can stay unmodified, which means upgrades won't require
> any re-application of changes.
>
> That said, you should be advised that simply hiding the HTML link for the
> admin doesn't mean that that the functionality is disabled - someone with
> knowledge of the Guacamole code and how the links are generated could
> retrieve the link and access the session, anyway. Removing the HTML link is
> just "security by obscurity."
>
> -Nick
>
>>
--
Best regards,
*Suat Toksöz*
Re: Apache Guacamole html page edit
Posted by Suat Toksöz <st...@gmail.com>.
Thanks Nick,
Then how can I modify the apache guacamole client , so no one can access to active session link from outside.
> On 1 Jun 2022, at 20:34, Nick Couchman <vn...@apache.org> wrote:
>
>
>> On Wed, Jun 1, 2022 at 12:54 PM Suat Toksöz <st...@gmail.com> wrote:
>
>> So, what is your suggestion for me to edit admin active session tab?
>>
>
> Creating a custom extension and using the HTML replace functionality is the best way to make sure that your changes are future-proof - the base of Guacamole Client can stay unmodified, which means upgrades won't require any re-application of changes.
>
> That said, you should be advised that simply hiding the HTML link for the admin doesn't mean that that the functionality is disabled - someone with knowledge of the Guacamole code and how the links are generated could retrieve the link and access the session, anyway. Removing the HTML link is just "security by obscurity."
>
> -Nick
Re: Apache Guacamole html page edit
Posted by Nick Couchman <vn...@apache.org>.
On Wed, Jun 1, 2022 at 12:54 PM Suat Toksöz <st...@gmail.com> wrote:
> So, what is your suggestion for me to edit admin active session tab?
>
>
Creating a custom extension and using the HTML replace functionality is the
best way to make sure that your changes are future-proof - the base of
Guacamole Client can stay unmodified, which means upgrades won't require
any re-application of changes.
That said, you should be advised that simply hiding the HTML link for the
admin doesn't mean that that the functionality is disabled - someone with
knowledge of the Guacamole code and how the links are generated could
retrieve the link and access the session, anyway. Removing the HTML link is
just "security by obscurity."
-Nick
>
Re: Apache Guacamole html page edit
Posted by Suat Toksöz <st...@gmail.com>.
So, what is your suggestion for me to edit admin active session tab?
> On 1 Jun 2022, at 19:25, Nick Couchman <vn...@apache.org> wrote:
>
>
>> On Wed, Jun 1, 2022 at 12:06 PM Joachim Lindenberg <gu...@lindenberg.one> wrote:
>
>> Two questions:
>>
>> can this be done with an extension rather than a modification?
> Yes, and this would be a better way to do it. You should be able to use the <meta> tag along with "replace", as documented in the guacamole-ext page in the manual, to replace the content that creates the link.
>
>> didn´t this come up several times earlier and could be a configuration option that the webapp addresses out-of-the-box?
> I don't think disabling this completely has come up; however, there is a PR in progress, along with a Jira issue, to notify users when someone joins and leaves the connection, so at least there is a visual cue for users that there is someone else on that connection.
>
> -NIck
Re: Apache Guacamole html page edit
Posted by Nick Couchman <vn...@apache.org>.
On Wed, Jun 1, 2022 at 12:06 PM Joachim Lindenberg <gu...@lindenberg.one>
wrote:
> Two questions:
>
> - can this be done with an extension rather than a modification?
>
> Yes, and this would be a better way to do it. You should be able to use
the <meta> tag along with "replace", as documented in the guacamole-ext
page in the manual, to replace the content that creates the link.
> -
> - didn´t this come up several times earlier and could be a
> configuration option that the webapp addresses out-of-the-box?
>
> I don't think disabling this completely has come up; however, there is a
PR in progress, along with a Jira issue, to notify users when someone joins
and leaves the connection, so at least there is a visual cue for users that
there is someone else on that connection.
-NIck
AW: Apache Guacamole html page edit
Posted by Joachim Lindenberg <gu...@lindenberg.one>.
Two questions:
* can this be done with an extension rather than a modification?
* didn´t this come up several times earlier and could be a configuration option that the webapp addresses out-of-the-box?
Thanks, Joachim
Von: Suat Toksöz <>
Gesendet: Wednesday, 1 June 2022 17:56
An: user@guacamole.apache.org
Betreff: Re: Apache Guacamole html page edit
Thanks Nick,
So İ need to get the apache guacamole client source code , then change the html tag ten compile and generate the war file for tomcat right?
The change that we newd is this, admin user should not able to intersep the active connections. So the link for each active session should be #.
On 1 Jun 2022, at 18:05, Nick Couchman <vnick@apache.org <ma...@apache.org> > wrote:
On Wed, Jun 1, 2022 at 10:47 AM Suat Toksöz <stoksoz@gmail.com <ma...@gmail.com> > wrote:
Also, I am not able to find the file location on apache guacamole source code.
https://dlcdn.apache.org/guacamole/1.4.0/source/
That's the guacamole-server (guacd) source code - the code for the web interface is in the guacamole-client source code. For the connection history and active sessions, the code is specifically, here:
https://github.com/apache/guacamole-client/tree/master/guacamole/src/main/frontend/src/app/settings/templates
Please note those are the HTML templates that are used by AngularJS to fill in the data. So, whatever modifications you want to do will likely need to be a combination of edits to those HTML templates as well as the AngularJS files that actually populate data.
-NIck
Re: Apache Guacamole html page edit
Posted by Suat Toksöz <st...@gmail.com>.
Thanks Nick,
So İ need to get the apache guacamole client source code , then change the html tag ten compile and generate the war file for tomcat right?
The change that we newd is this, admin user should not able to intersep the active connections. So the link for each active session should be #.
> On 1 Jun 2022, at 18:05, Nick Couchman <vn...@apache.org> wrote:
>
>
>> On Wed, Jun 1, 2022 at 10:47 AM Suat Toksöz <st...@gmail.com> wrote:
>
>> Also, I am not able to find the file location on apache guacamole source code.
>>
>> https://dlcdn.apache.org/guacamole/1.4.0/source/
>>
>>
>
> That's the guacamole-server (guacd) source code - the code for the web interface is in the guacamole-client source code. For the connection history and active sessions, the code is specifically, here:
>
> https://github.com/apache/guacamole-client/tree/master/guacamole/src/main/frontend/src/app/settings/templates
>
> Please note those are the HTML templates that are used by AngularJS to fill in the data. So, whatever modifications you want to do will likely need to be a combination of edits to those HTML templates as well as the AngularJS files that actually populate data.
>
> -NIck
Re: Apache Guacamole html page edit
Posted by Nick Couchman <vn...@apache.org>.
On Wed, Jun 1, 2022 at 10:47 AM Suat Toksöz <st...@gmail.com> wrote:
> Also, I am not able to find the file location on apache guacamole source
> code.
>
> https://dlcdn.apache.org/guacamole/1.4.0/source/
> [image: image.png]
>
>
That's the guacamole-server (guacd) source code - the code for the web
interface is in the guacamole-client source code. For the connection
history and active sessions, the code is specifically, here:
https://github.com/apache/guacamole-client/tree/master/guacamole/src/main/frontend/src/app/settings/templates
Please note those are the HTML templates that are used by AngularJS to fill
in the data. So, whatever modifications you want to do will likely need to
be a combination of edits to those HTML templates as well as the AngularJS
files that actually populate data.
-NIck
>
Re: Apache Guacamole html page edit
Posted by Tushar Jain <tu...@hotmail.com>.
That’s the server code you are looking at. Instead, you have to download the client code. Following is the location:
https://github.com/apache/guacamole-client
[https://opengraph.githubassets.com/7090848d7aceb6ab363d51e09d02c07d6fe6b51e0fd4b0fe2d3f9ac66a4b0c2f/apache/guacamole-client]<https://github.com/apache/guacamole-client>
apache/guacamole-client: Mirror of Apache Guacamole Client - GitHub<https://github.com/apache/guacamole-client>
Mirror of Apache Guacamole Client. Contribute to apache/guacamole-client development by creating an account on GitHub.
github.com
________________________________
From: Suat Toksöz <st...@gmail.com>
Sent: Wednesday, June 1, 2022 8:17 PM
To: user@guacamole.apache.org <us...@guacamole.apache.org>
Subject: Re: Apache Guacamole html page edit
Also, I am not able to find the file location on apache guacamole source code.
https://dlcdn.apache.org/guacamole/1.4.0/source/
[image.png]
On Wed, Jun 1, 2022 at 9:11 AM Suat Toksöz <st...@gmail.com>> wrote:
Thanks Nick for the quick response.
I want to edit WAR file (https://guacamole.apache.org/releases/1.4.0/) and re build the WAR file then deploy to the tomcat server. But, I can not able to find html section to edit. We want to edit the "Active Session" section of the admin page, where I can find the html files for this on the WAR file.
[image.png]
Thanks
On Tue, May 31, 2022 at 5:58 PM Nick Couchman <vn...@apache.org>> wrote:
On Tue, May 31, 2022 at 10:13 AM Suat Toksöz <st...@gmail.com>> wrote:
Hi,
I would like to edit apache guacamole admin web site, where I can find the html tags?
If you want to edit the admin site, you should edit the source code and re-builld it, and not edit the pages directly. As the site is hosted by Tomcat, the static pages are deployed from the WAR file, which can be re-deployed at any time and will overwrite any changes you make.
To edit the source code, you can either edit the source directly and rebuild the war, or you can build an extension module that modifies the HTML code dynamically. The second option is the recommended route.
To edit the source code directly, you need to download the source code and then find the location that you want to edit in the guacamole/src/main/frontend/src/app directory.
If you want to build an extension that modifies the HTML, see the following manual page, and the following branding example:
https://guacamole.apache.org/doc/gug/guacamole-ext.html#updating-existing-html
https://github.com/apache/guacamole-client/tree/master/doc/guacamole-branding-example
Feel free to post back here with any further questions or concerns.
-Nick
--
Best regards,
Suat Toksöz
--
Best regards,
Suat Toksöz
Re: Apache Guacamole html page edit
Posted by Suat Toksöz <st...@gmail.com>.
Also, I am not able to find the file location on apache guacamole source
code.
https://dlcdn.apache.org/guacamole/1.4.0/source/
[image: image.png]
On Wed, Jun 1, 2022 at 9:11 AM Suat Toksöz <st...@gmail.com> wrote:
> Thanks Nick for the quick response.
>
> I want to edit WAR file (https://guacamole.apache.org/releases/1.4.0/)
> and re build the WAR file then deploy to the tomcat server. But, I can not
> able to find html section to edit. We want to edit the "Active Session"
> section of the admin page, where I can find the html files for this on the
> WAR file.
>
> [image: image.png]
> Thanks
>
>
> On Tue, May 31, 2022 at 5:58 PM Nick Couchman <vn...@apache.org> wrote:
>
>> On Tue, May 31, 2022 at 10:13 AM Suat Toksöz <st...@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> I would like to edit apache guacamole admin web site, where I can find
>>> the html tags?
>>>
>>>
>> If you want to edit the admin site, you should edit the source code and
>> re-builld it, and not edit the pages directly. As the site is hosted by
>> Tomcat, the static pages are deployed from the WAR file, which can be
>> re-deployed at any time and will overwrite any changes you make.
>>
>> To edit the source code, you can either edit the source directly and
>> rebuild the war, or you can build an extension module that modifies the
>> HTML code dynamically. The second option is the recommended route.
>>
>> To edit the source code directly, you need to download the source code
>> and then find the location that you want to edit in the
>> guacamole/src/main/frontend/src/app directory.
>>
>> If you want to build an extension that modifies the HTML, see the
>> following manual page, and the following branding example:
>>
>> https://guacamole.apache.org/doc/gug/guacamole-ext.html#updating-existing-html
>>
>> https://github.com/apache/guacamole-client/tree/master/doc/guacamole-branding-example
>>
>> Feel free to post back here with any further questions or concerns.
>>
>> -Nick
>>
>>>
>
> --
>
> Best regards,
>
> *Suat Toksöz*
>
--
Best regards,
*Suat Toksöz*
Re: Apache Guacamole html page edit
Posted by Suat Toksöz <st...@gmail.com>.
Thanks Nick for the quick response.
I want to edit WAR file (https://guacamole.apache.org/releases/1.4.0/) and
re build the WAR file then deploy to the tomcat server. But, I can not able
to find html section to edit. We want to edit the "Active Session" section
of the admin page, where I can find the html files for this on the WAR file.
[image: image.png]
Thanks
On Tue, May 31, 2022 at 5:58 PM Nick Couchman <vn...@apache.org> wrote:
> On Tue, May 31, 2022 at 10:13 AM Suat Toksöz <st...@gmail.com> wrote:
>
>> Hi,
>>
>> I would like to edit apache guacamole admin web site, where I can find
>> the html tags?
>>
>>
> If you want to edit the admin site, you should edit the source code and
> re-builld it, and not edit the pages directly. As the site is hosted by
> Tomcat, the static pages are deployed from the WAR file, which can be
> re-deployed at any time and will overwrite any changes you make.
>
> To edit the source code, you can either edit the source directly and
> rebuild the war, or you can build an extension module that modifies the
> HTML code dynamically. The second option is the recommended route.
>
> To edit the source code directly, you need to download the source code and
> then find the location that you want to edit in the
> guacamole/src/main/frontend/src/app directory.
>
> If you want to build an extension that modifies the HTML, see the
> following manual page, and the following branding example:
>
> https://guacamole.apache.org/doc/gug/guacamole-ext.html#updating-existing-html
>
> https://github.com/apache/guacamole-client/tree/master/doc/guacamole-branding-example
>
> Feel free to post back here with any further questions or concerns.
>
> -Nick
>
>>
--
Best regards,
*Suat Toksöz*
Re: Apache Guacamole html page edit
Posted by Nick Couchman <vn...@apache.org>.
On Tue, May 31, 2022 at 10:13 AM Suat Toksöz <st...@gmail.com> wrote:
> Hi,
>
> I would like to edit apache guacamole admin web site, where I can find the
> html tags?
>
>
If you want to edit the admin site, you should edit the source code and
re-builld it, and not edit the pages directly. As the site is hosted by
Tomcat, the static pages are deployed from the WAR file, which can be
re-deployed at any time and will overwrite any changes you make.
To edit the source code, you can either edit the source directly and
rebuild the war, or you can build an extension module that modifies the
HTML code dynamically. The second option is the recommended route.
To edit the source code directly, you need to download the source code and
then find the location that you want to edit in the
guacamole/src/main/frontend/src/app directory.
If you want to build an extension that modifies the HTML, see the following
manual page, and the following branding example:
https://guacamole.apache.org/doc/gug/guacamole-ext.html#updating-existing-html
https://github.com/apache/guacamole-client/tree/master/doc/guacamole-branding-example
Feel free to post back here with any further questions or concerns.
-Nick
>