You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 14:47:49 UTC
[I] BrokerCluster should not fall back to mock infrastructure rows on API failure [rocketmq-dashboard]
Aias00 opened a new issue, #870:
URL: https://github.com/apache/rocketmq-dashboard/issues/870
### Problem
`web/src/pages/studio/BrokerCluster.tsx` still initializes Broker, NameServer, and Proxy tables with local mock rows and keeps those rows when `listClusters()` fails. The current test suite also asserts this fallback behavior.
This means a real API failure can leave Studio showing hard-coded infrastructure nodes, which is misleading for the Control Plane / ARCH-01 cluster management view.
A previous issue (#700) was closed by #701, but the current `rocketmq-studio` branch still contains this fallback behavior.
### Expected behavior
- The page should start with empty Broker/NameServer/Proxy tables.
- Successful `listClusters()` responses should populate the tables.
- Failed `listClusters()` calls should show the existing error message and leave the tables empty or keep the last real response, not local mock rows.
- Tests should assert that API failure does not render hard-coded mock infrastructure data.
### Scope
RocketMQ Studio / Track 1 / ARCH-01 cluster and proxy management view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] BrokerCluster should not fall back to mock infrastructure rows on API failure [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #870:
URL: https://github.com/apache/rocketmq-dashboard/issues/870#issuecomment-5177583822
Resolved by #950 (merged into rocketmq-studio as 2fc9ebd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] BrokerCluster should not fall back to mock infrastructure rows on API failure [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #870: BrokerCluster should not fall back to mock infrastructure rows on API failure
URL: https://github.com/apache/rocketmq-dashboard/issues/870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] BrokerCluster should not fall back to mock infrastructure rows on API failure [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on issue #870:
URL: https://github.com/apache/rocketmq-dashboard/issues/870#issuecomment-5176716351
I found the same fallback below the BrokerCluster page: `ClusterService.listClusters()` returns the production `ClusterRepositoryImpl` sample clusters whenever live discovery is empty, and the MCP `rmq.cluster.list` tool consumes that service as well. I will extend the fix to the server-side/MCP boundary so unavailable discovery never becomes fabricated cluster data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org