You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/10/05 18:45:32 UTC
[kudu-CR] docs: clarify directory configs and usage
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8220
Change subject: docs: clarify directory configs and usage
......................................................................
docs: clarify directory configs and usage
Added a short blurb about what the various directory flags are used for
and some notes about them (e.g. fs_wal_dir is ideally high-performance,
multiple fs_data_dirs stripes data, etc.).
Also updated the migration docs to clarify tool usage to avoid confusion
around `--fs_wal_dir=<master_data_dir>`.
Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
---
M docs/administration.adoc
M docs/configuration.adoc
2 files changed, 31 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/8220/1
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] docs: clarify directory configs and usage
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8220 )
Change subject: docs: clarify directory configs and usage
......................................................................
Patch Set 1:
(2 comments)
e
http://gerrit.cloudera.org:8080/#/c/8220/1/docs/configuration.adoc
File docs/configuration.adoc:
http://gerrit.cloudera.org:8080/#/c/8220/1/docs/configuration.adoc@65
PS1, Line 65: high-performance drive
Maybe we should be a little more specific? "High bandwidth, low latency" perhaps? Or give an example (i.e. "such as an SSD").
http://gerrit.cloudera.org:8080/#/c/8220/1/docs/configuration.adoc@66
PS1, Line 66: multiple are specified
Maybe "This is a comma-separated list of directories; if multiple entries are provided, ..."
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 20:46:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: clarify directory configs and usage
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8220
to look at the new patch set (#2).
Change subject: docs: clarify directory configs and usage
......................................................................
docs: clarify directory configs and usage
Added a short blurb about how the various directory flags are used and
some notes about them (e.g. fs_wal_dir is ideally high-performance,
multiple fs_data_dirs stripes data, etc.).
Also updated the migration docs to clarify tool usage to avoid confusion
around `--fs_wal_dir=<master_data_dir>`.
Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
---
M docs/administration.adoc
M docs/configuration.adoc
2 files changed, 46 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/8220/2
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] docs: clarify directory configs and usage
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8220 )
Change subject: docs: clarify directory configs and usage
......................................................................
docs: clarify directory configs and usage
Added a short blurb about how the various directory flags are used and
some notes about them (e.g. fs_wal_dir is ideally high-performance,
multiple fs_data_dirs stripes data, etc.).
Also updated the migration docs to clarify tool usage to avoid confusion
around `--fs_wal_dir=<master_data_dir>`.
Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Reviewed-on: http://gerrit.cloudera.org:8080/8220
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M docs/administration.adoc
M docs/configuration.adoc
2 files changed, 47 insertions(+), 31 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] docs: clarify directory configs and usage
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8220 )
Change subject: docs: clarify directory configs and usage
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 22:32:59 +0000
Gerrit-HasComments: No
[kudu-CR] docs: clarify directory configs and usage
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8220 )
Change subject: docs: clarify directory configs and usage
......................................................................
Patch Set 1:
Not super confident in the `--fs_wal_dir=<master_data_dir>` change, but I figured it's at least intuitive and "correct" to update by including `--fs_data_dirs` as well.
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 18:47:48 +0000
Gerrit-HasComments: No
[kudu-CR] docs: clarify directory configs and usage
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8220 )
Change subject: docs: clarify directory configs and usage
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2017 03:32:50 +0000
Gerrit-HasComments: No
[kudu-CR] docs: clarify directory configs and usage
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8220
to look at the new patch set (#3).
Change subject: docs: clarify directory configs and usage
......................................................................
docs: clarify directory configs and usage
Added a short blurb about how the various directory flags are used and
some notes about them (e.g. fs_wal_dir is ideally high-performance,
multiple fs_data_dirs stripes data, etc.).
Also updated the migration docs to clarify tool usage to avoid confusion
around `--fs_wal_dir=<master_data_dir>`.
Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
---
M docs/administration.adoc
M docs/configuration.adoc
2 files changed, 47 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/8220/3
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] docs: clarify directory configs and usage
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8220 )
Change subject: docs: clarify directory configs and usage
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8220/1/docs/configuration.adoc
File docs/configuration.adoc:
http://gerrit.cloudera.org:8080/#/c/8220/1/docs/configuration.adoc@65
PS1, Line 65: high-performance drive
> Maybe we should be a little more specific? "High bandwidth, low latency" pe
Done
http://gerrit.cloudera.org:8080/#/c/8220/1/docs/configuration.adoc@66
PS1, Line 66: irs` configuration ind
> Maybe "This is a comma-separated list of directories; if multiple entries a
This is already noted below, although maybe we should omit some of the descriptions in the tables below. I'll collate them here since directory flags are node-agnostic.
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 22:15:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: clarify directory configs and usage
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8220 )
Change subject: docs: clarify directory configs and usage
......................................................................
Patch Set 3:
Fixed a few grammar nits, otherwise pretty much unchanged.
--
To view, visit http://gerrit.cloudera.org:8080/8220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia389da6421bddc3d19cbf7a49b4d3b8b59858f28
Gerrit-Change-Number: 8220
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2017 02:34:39 +0000
Gerrit-HasComments: No