[GitHub] [iceberg] nastra commented on a diff in pull request #7694: Build: Replace usage of Nebula dependency recommender plugin with Gradle's versionCatalog

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1213179471


##########
settings.gradle:
##########
@@ -192,3 +194,186 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
   }
 }
 
+dependencyResolutionManagement {
+  versionCatalogs {
+    libs {
+      String antlrVersion = "4.8"
+      String awsSdkVersion = "2.20.18"
+      String flink15Version = "1.15.0"
+      String flink16Version = "1.16.1"
+      String flink17Version = "1.17.0"
+      String hadoop2Version = "2.7.3"
+      String hive2Version = "2.3.9"
+      String hive3Version = "3.1.3"
+      String jackson11Version = "2.11.4"

Review Comment:
   nit: maybe `jackson211Version` instead of `jackson11Version`? Same for the others



##########
settings.gradle:
##########
@@ -192,3 +194,186 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
   }
 }
 
+dependencyResolutionManagement {

Review Comment:
   do you know if dependabot is able to automatically update these dependencies whenever there's a new version? I think it would be good to define the versions in a `versions.toml` file, wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org