You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@geode.apache.org by Sai Boorlagadda <sa...@apache.org> on 2018/04/05 19:16:27 UTC

[PROPOSAL]: deprecating gfsh command option --load-cluster-config-from-dir for 'start locator'

All,

Currently this option takes (true/false, defaults to false) to let locator
load cluster configuration from a specified directory provided with other
option '--cluster-config-dir'. Also `--cluster-config-dir` is used to
create the persistent disk store to store configuration region entries.

There are couple of issues on how these two parameters work together. When
starting a locator to join an existing cluster -

1) if option `--load-cluster-config-from-dir` is set to true, then users
have to provide a directory to load the configuration, failing to provide
`--cluster-config-dir` would cause the newly started locator to wipe out
existing configuration if no configuration is found (`--cluster-config-dir`
defaults to locators working directory).

2) users have to leave `load-cluster-configuration-dir=false` when
specifying a directory for persistent region to be used. Otherwise the
existing configuration is wiped out by the newly started locator as it
finds the directory provided by `--cluster-config-dir` is empty. (here
user's intent to provide a specific directory is to create the disk store
and not to load configuration from it). Unlike issue #1, users does not
need to be cautious in this case as the default value for
load-cluster-configuration-from-dir is 'false'.

Its not very intuitive how these two parameters work together, so in favor
of simplicity this command option will be deprecated and users can rely on
'import cluster-configuration' command to import configuration while
bootstrapping a cluster.

In the past this option has created few issues: GEODE-3237, GEODE-4218.

Sai

Re: [PROPOSAL]: deprecating gfsh command option --load-cluster-config-from-dir for 'start locator'

Posted by Michael Stolz <ms...@pivotal.io>.
There could be. For instance, in a cloud environment, the working directory
could be on transient disk. The cluster configuration should, however,
always be on permanent disk.

--
Mike Stolz
Principal Engineer, GemFire Product Lead
Mobile: +1-631-835-4771
Download the new GemFire book here.
<https://content.pivotal.io/ebooks/scaling-data-services-with-pivotal-gemfire>

On Thu, Apr 5, 2018 at 4:22 PM, Jinmei Liao <ji...@pivotal.io> wrote:

> +1 for deprecating "--load-cluster-configuration-dir" option in favor of
> "import cluster-configuration" for a more explicit intention.
>
> Also, since we are deprecating "load-cluster-configuration-dir", should
> we also deprecate "-cluster-config-dir" as well. Is there any need for
> users to persist the cluster configuration in a place other than the
> working dir?
>
> On Thu, Apr 5, 2018 at 12:16 PM, Sai Boorlagadda <
> sai_boorlagadda@apache.org> wrote:
>
>> All,
>>
>> Currently this option takes (true/false, defaults to false) to let
>> locator load cluster configuration from a specified directory provided with
>> other option '--cluster-config-dir'. Also `--cluster-config-dir` is used to
>> create the persistent disk store to store configuration region entries.
>>
>> There are couple of issues on how these two parameters work together. When
>> starting a locator to join an existing cluster -
>>
>> 1) if option `--load-cluster-config-from-dir` is set to true, then users
>> have to provide a directory to load the configuration, failing to provide
>> `--cluster-config-dir` would cause the newly started locator to wipe out
>> existing configuration if no configuration is found (`--cluster-config-dir`
>> defaults to locators working directory).
>>
>> 2) users have to leave `load-cluster-configuration-dir=false` when
>> specifying a directory for persistent region to be used. Otherwise the
>> existing configuration is wiped out by the newly started locator as it
>> finds the directory provided by `--cluster-config-dir` is empty. (here
>> user's intent to provide a specific directory is to create the disk store
>> and not to load configuration from it). Unlike issue #1, users does not
>> need to be cautious in this case as the default value for
>> load-cluster-configuration-from-dir is 'false'.
>>
>> Its not very intuitive how these two parameters work together, so in
>> favor of simplicity this command option will be deprecated and users can
>> rely on 'import cluster-configuration' command to import configuration
>> while bootstrapping a cluster.
>>
>> In the past this option has created few issues: GEODE-3237, GEODE-4218.
>>
>> Sai
>>
>
>
>
> --
> Cheers
>
> Jinmei
>

Re: [PROPOSAL]: deprecating gfsh command option --load-cluster-config-from-dir for 'start locator'

Posted by Michael Stolz <ms...@pivotal.io>.
There could be. For instance, in a cloud environment, the working directory
could be on transient disk. The cluster configuration should, however,
always be on permanent disk.

--
Mike Stolz
Principal Engineer, GemFire Product Lead
Mobile: +1-631-835-4771
Download the new GemFire book here.
<https://content.pivotal.io/ebooks/scaling-data-services-with-pivotal-gemfire>

On Thu, Apr 5, 2018 at 4:22 PM, Jinmei Liao <ji...@pivotal.io> wrote:

> +1 for deprecating "--load-cluster-configuration-dir" option in favor of
> "import cluster-configuration" for a more explicit intention.
>
> Also, since we are deprecating "load-cluster-configuration-dir", should
> we also deprecate "-cluster-config-dir" as well. Is there any need for
> users to persist the cluster configuration in a place other than the
> working dir?
>
> On Thu, Apr 5, 2018 at 12:16 PM, Sai Boorlagadda <
> sai_boorlagadda@apache.org> wrote:
>
>> All,
>>
>> Currently this option takes (true/false, defaults to false) to let
>> locator load cluster configuration from a specified directory provided with
>> other option '--cluster-config-dir'. Also `--cluster-config-dir` is used to
>> create the persistent disk store to store configuration region entries.
>>
>> There are couple of issues on how these two parameters work together. When
>> starting a locator to join an existing cluster -
>>
>> 1) if option `--load-cluster-config-from-dir` is set to true, then users
>> have to provide a directory to load the configuration, failing to provide
>> `--cluster-config-dir` would cause the newly started locator to wipe out
>> existing configuration if no configuration is found (`--cluster-config-dir`
>> defaults to locators working directory).
>>
>> 2) users have to leave `load-cluster-configuration-dir=false` when
>> specifying a directory for persistent region to be used. Otherwise the
>> existing configuration is wiped out by the newly started locator as it
>> finds the directory provided by `--cluster-config-dir` is empty. (here
>> user's intent to provide a specific directory is to create the disk store
>> and not to load configuration from it). Unlike issue #1, users does not
>> need to be cautious in this case as the default value for
>> load-cluster-configuration-from-dir is 'false'.
>>
>> Its not very intuitive how these two parameters work together, so in
>> favor of simplicity this command option will be deprecated and users can
>> rely on 'import cluster-configuration' command to import configuration
>> while bootstrapping a cluster.
>>
>> In the past this option has created few issues: GEODE-3237, GEODE-4218.
>>
>> Sai
>>
>
>
>
> --
> Cheers
>
> Jinmei
>

Re: [PROPOSAL]: deprecating gfsh command option --load-cluster-config-from-dir for 'start locator'

Posted by Jinmei Liao <ji...@pivotal.io>.
+1 for deprecating "--load-cluster-configuration-dir" option in favor of
"import cluster-configuration" for a more explicit intention.

Also, since we are deprecating "load-cluster-configuration-dir", should we
also deprecate "-cluster-config-dir" as well. Is there any need for users
to persist the cluster configuration in a place other than the working dir?

On Thu, Apr 5, 2018 at 12:16 PM, Sai Boorlagadda <sai_boorlagadda@apache.org
> wrote:

> All,
>
> Currently this option takes (true/false, defaults to false) to let locator
> load cluster configuration from a specified directory provided with other
> option '--cluster-config-dir'. Also `--cluster-config-dir` is used to
> create the persistent disk store to store configuration region entries.
>
> There are couple of issues on how these two parameters work together. When
> starting a locator to join an existing cluster -
>
> 1) if option `--load-cluster-config-from-dir` is set to true, then users
> have to provide a directory to load the configuration, failing to provide
> `--cluster-config-dir` would cause the newly started locator to wipe out
> existing configuration if no configuration is found (`--cluster-config-dir`
> defaults to locators working directory).
>
> 2) users have to leave `load-cluster-configuration-dir=false` when
> specifying a directory for persistent region to be used. Otherwise the
> existing configuration is wiped out by the newly started locator as it
> finds the directory provided by `--cluster-config-dir` is empty. (here
> user's intent to provide a specific directory is to create the disk store
> and not to load configuration from it). Unlike issue #1, users does not
> need to be cautious in this case as the default value for
> load-cluster-configuration-from-dir is 'false'.
>
> Its not very intuitive how these two parameters work together, so in favor
> of simplicity this command option will be deprecated and users can rely on
> 'import cluster-configuration' command to import configuration while
> bootstrapping a cluster.
>
> In the past this option has created few issues: GEODE-3237, GEODE-4218.
>
> Sai
>



-- 
Cheers

Jinmei

Re: [PROPOSAL]: deprecating gfsh command option --load-cluster-config-from-dir for 'start locator'

Posted by Jinmei Liao <ji...@pivotal.io>.
+1 for deprecating "--load-cluster-configuration-dir" option in favor of
"import cluster-configuration" for a more explicit intention.

Also, since we are deprecating "load-cluster-configuration-dir", should we
also deprecate "-cluster-config-dir" as well. Is there any need for users
to persist the cluster configuration in a place other than the working dir?

On Thu, Apr 5, 2018 at 12:16 PM, Sai Boorlagadda <sai_boorlagadda@apache.org
> wrote:

> All,
>
> Currently this option takes (true/false, defaults to false) to let locator
> load cluster configuration from a specified directory provided with other
> option '--cluster-config-dir'. Also `--cluster-config-dir` is used to
> create the persistent disk store to store configuration region entries.
>
> There are couple of issues on how these two parameters work together. When
> starting a locator to join an existing cluster -
>
> 1) if option `--load-cluster-config-from-dir` is set to true, then users
> have to provide a directory to load the configuration, failing to provide
> `--cluster-config-dir` would cause the newly started locator to wipe out
> existing configuration if no configuration is found (`--cluster-config-dir`
> defaults to locators working directory).
>
> 2) users have to leave `load-cluster-configuration-dir=false` when
> specifying a directory for persistent region to be used. Otherwise the
> existing configuration is wiped out by the newly started locator as it
> finds the directory provided by `--cluster-config-dir` is empty. (here
> user's intent to provide a specific directory is to create the disk store
> and not to load configuration from it). Unlike issue #1, users does not
> need to be cautious in this case as the default value for
> load-cluster-configuration-from-dir is 'false'.
>
> Its not very intuitive how these two parameters work together, so in favor
> of simplicity this command option will be deprecated and users can rely on
> 'import cluster-configuration' command to import configuration while
> bootstrapping a cluster.
>
> In the past this option has created few issues: GEODE-3237, GEODE-4218.
>
> Sai
>



-- 
Cheers

Jinmei