You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dinesh Joshi (Jira)" <ji...@apache.org> on 2020/02/17 20:20:00 UTC
[jira] [Commented] (CASSANDRA-14888) Several mbeans are not
unregistered when dropping a keyspace and table
[ https://issues.apache.org/jira/browse/CASSANDRA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038601#comment-17038601 ]
Dinesh Joshi commented on CASSANDRA-14888:
------------------------------------------
[~stillalex] I'm revisiting this ticket. I think we need to go further to ensure that future metrics are released properly without excessive manual intervention. We should follow a pattern where we use a factory to register all kinds of releasable metrics which doesn't seem to be the case right now. Once we have that we can iterate over them in the release method much like what we do for Metric instances and call release on them.
> Several mbeans are not unregistered when dropping a keyspace and table
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-14888
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14888
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
> Reporter: Ariel Weisberg
> Assignee: Alex Deparvu
> Priority: Urgent
> Labels: patch-available
> Fix For: 4.0, 4.0-rc
>
> Attachments: CASSANDRA-14888.patch
>
>
> CasCommit, CasPrepare, CasPropose, ReadRepairRequests, ShortReadProtectionRequests, AntiCompactionTime, BytesValidated, PartitionsValidated, RepairPrepareTime, RepairSyncTime, RepairedDataInconsistencies, ViewLockAcquireTime, ViewReadTime, WriteFailedIdealCL
> Basically for 3 years people haven't known what they are doing because the entire thing is kind of obscure. Fix it and also add a dtest that detects if any mbeans are left behind after dropping a table and keyspace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org