You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dineshkumar Yadav <di...@outlook.com> on 2020/10/30 15:58:18 UTC
Review Request 72996: RANGER-3064 : keyadmin user able to see all the
policy through curl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72996/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
Repository: ranger
Description
-------
keyadmin user able to see all the policy through curl using API '/service/public/v2/api/policy' but from UI he is able to see only kms service policies.
Solution: 1. Keyadmin user should only see kms policy.
2. Admin user should only see admin policy.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 4ef9abeb8
Diff: https://reviews.apache.org/r/72996/diff/1/
Testing
-------
After patch
Keyadmin user get kms policy only
admin user get admin policy only
Thanks,
Dineshkumar Yadav
Re: Review Request 72996: RANGER-3064 : keyadmin user able to see all
the policy through curl
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72996/#review222149
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 30, 2020, 3:58 p.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72996/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2020, 3:58 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> keyadmin user able to see all the policy through curl using API '/service/public/v2/api/policy' but from UI he is able to see only kms service policies.
>
> Solution: 1. Keyadmin user should only see kms policy.
> 2. Admin user should only see admin policy.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 4ef9abeb8
>
>
> Diff: https://reviews.apache.org/r/72996/diff/1/
>
>
> Testing
> -------
>
> After patch
> Keyadmin user get kms policy only
> admin user get admin policy only
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 72996: RANGER-3064 : Make policy API consistent
with the UI behavior for keyadmin role
Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72996/#review222155
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Nov. 2, 2020, 6:11 a.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72996/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2020, 6:11 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Solution: There should be consistent behavior for keydmin role from UI and policy API.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 4ef9abeb8
>
>
> Diff: https://reviews.apache.org/r/72996/diff/2/
>
>
> Testing
> -------
>
> After patch
> keydmin role is now able see consistent behavior from UI and policy API.
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 72996: RANGER-3064 : Make policy API consistent
with the UI behavior for keyadmin role
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72996/
-----------------------------------------------------------
(Updated Nov. 2, 2020, 6:11 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
Summary (updated)
-----------------
RANGER-3064 : Make policy API consistent with the UI behavior for keyadmin role
Repository: ranger
Description (updated)
-------
Solution: There should be consistent behavior for keydmin role from UI and policy API.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 4ef9abeb8
Diff: https://reviews.apache.org/r/72996/diff/2/
Changes: https://reviews.apache.org/r/72996/diff/1-2/
Testing (updated)
-------
After patch
keydmin role is now able see consistent behavior from UI and policy API.
Thanks,
Dineshkumar Yadav