You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by roshan <gi...@git.apache.org> on 2015/06/27 08:07:50 UTC
[GitHub] thrift pull request: THRIFT-3193 Provide an option to use undated ...
GitHub user roshan opened a pull request:
https://github.com/apache/thrift/pull/531
THRIFT-3193 Provide an option to use undated @Generated annotations
The `@Generated` Java annotation has an optional date parameter. If this is generated by Thrift, then it becomes a bit of a pain to find the few generated files you care about and check them in (since everything will diff).
We just auto-generate files and check them in, and this would result in commits with every file changing. This patch allows us to disable the date annotation when generating.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/roshan/thrift THRIFT-3193_suppress_date_value_for_generated_annotation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/531.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #531
----
commit 521b208d4257f686b1efd19eeb60eb28a7684fda
Author: Roshan George <ro...@arjie.com>
Date: 2015-06-27T06:05:02Z
Provide an option to use undated @Generated annotations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3193 Provide an option to use undated ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/531
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---