You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/01 17:10:21 UTC
[GitHub] [superset] ktmud opened a new pull request, #20937: fix(sqllab): tracking url and error alert padding
ktmud opened a new pull request, #20937:
URL: https://github.com/apache/superset/pull/20937
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Add back the missing space between tracking url button and alert messages when SQL Lab query results failed.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### Before
<img width="940" alt="Xnip2022-08-01_10-07-06" src="https://user-images.githubusercontent.com/335541/182204790-3882f961-c984-43bf-aefa-596913f6c2f1.png">
#### After
<img width="928" alt="Xnip2022-08-01_10-08-38" src="https://user-images.githubusercontent.com/335541/182204802-038449bc-948b-4631-bab6-b268c7d00f66.png">
### TESTING INSTRUCTIONS
Run a failed query in Presto
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #20937: fix(sqllab): tracking url and error alert padding
Posted by GitBox <gi...@apache.org>.
ktmud merged PR #20937:
URL: https://github.com/apache/superset/pull/20937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org