You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@shindig.apache.org by "Niekerk, C. van (Charl, ICTS)" <c....@utwente.nl> on 2013/07/01 10:07:58 UTC
Re: Replacement for iGoogle gadgetsettings
On Fri, Jun 28, 2013 at 03:32:51PM -0400, Ryan Baxter wrote:
> Thanks Charl! Are you interested in contributing something more
> formal, maybe in the way of a wiki article? Or better yet a patch to
> the shindig 2.0 code base so that we could do a release with you code
> in it?
I would most certainly like to try my hand at integrating this directly into Shindig 2.0.
That actually sounds like the most logical place for it, but I didn't want to "fork" the code base on my own.
If you would consider including this in a release, that would be awesome, although it will need to be tested much more thoroughly first.
Am I correct that this needs to be integrated into the following subversion branch?
http://svn.apache.org/repos/asf/shindig/branches/2.0.x/
I might need to reformat the code as well to fit into your code conventions, but it seems like the link to the wiki is broken on:
http://shindig.apache.org/code_conventions.html
Best Regards,
Charl
--
Charl van Niekerk
ICT Service Centre
University of Twente
Re: Replacement for iGoogle gadgetsettings
Posted by Ryan Baxter <rb...@apache.org>.
On Tue, Jul 2, 2013 at 3:30 AM, Niekerk, C. van (Charl, ICTS)
<c....@utwente.nl> wrote:
> On Mon, Jul 01, 2013 at 05:25:55PM -0400, Ryan Baxter wrote:
>> I just did
>>
>> $ svn co http://svn.apache.org/repos/asf/shindig/branches/2.0.x shindig-2.0.x
>> $ cd shindig-2.0.x
>> $ mvn
>>
>> And everything build successfully. I believe the default goal set in
>> the pom is install which includes compile, try that.
>
> Found the problem - it appears I was building with OpenJDK 6. I selected OpenJDK 7 as my default Java version and the build was successful (mvn compile works too).
>
> The virtual machine I use to run the Shindig 2.0.x release has Oracle Java 6 installed. Should have checked this first, my bad.
>
> Now on to integrating the code... If I have questions regarding this, should I ask them on shindig-dev instead?
Yes that is the best place.
>
> Best Regards,
> Charl
>
> --
> Charl van Niekerk
> ICT Service Centre
> University of Twente
Re: Replacement for iGoogle gadgetsettings
Posted by "Niekerk, C. van (Charl, ICTS)" <c....@utwente.nl>.
On Mon, Jul 01, 2013 at 05:25:55PM -0400, Ryan Baxter wrote:
> I just did
>
> $ svn co http://svn.apache.org/repos/asf/shindig/branches/2.0.x shindig-2.0.x
> $ cd shindig-2.0.x
> $ mvn
>
> And everything build successfully. I believe the default goal set in
> the pom is install which includes compile, try that.
Found the problem - it appears I was building with OpenJDK 6. I selected OpenJDK 7 as my default Java version and the build was successful (mvn compile works too).
The virtual machine I use to run the Shindig 2.0.x release has Oracle Java 6 installed. Should have checked this first, my bad.
Now on to integrating the code... If I have questions regarding this, should I ask them on shindig-dev instead?
Best Regards,
Charl
--
Charl van Niekerk
ICT Service Centre
University of Twente
Re: Replacement for iGoogle gadgetsettings
Posted by Ryan Baxter <rb...@apache.org>.
I just did
$ svn co http://svn.apache.org/repos/asf/shindig/branches/2.0.x shindig-2.0.x
$ cd shindig-2.0.x
$ mvn
And everything build successfully. I believe the default goal set in
the pom is install which includes compile, try that.
On Mon, Jul 1, 2013 at 11:16 AM, Niekerk, C. van (Charl, ICTS)
<c....@utwente.nl> wrote:
> On Mon, Jul 01, 2013 at 09:32:41AM -0400, Ryan Baxter wrote:
>> Which directory did you run mvn compile in? You should just be able
>> to run mvn in the top level folder.
>
> I did the following:
>
> $ svn co http://svn.apache.org/repos/asf/shindig/branches/2.0.x shindig-2.0.x
> $ cd shindig-2.0.x
> $ mvn compile
>
> Best Regards,
> Charl
>
> --
> Charl van Niekerk
> ICT Service Centre
> University of Twente
Re: Replacement for iGoogle gadgetsettings
Posted by "Niekerk, C. van (Charl, ICTS)" <c....@utwente.nl>.
On Mon, Jul 01, 2013 at 09:32:41AM -0400, Ryan Baxter wrote:
> Which directory did you run mvn compile in? You should just be able
> to run mvn in the top level folder.
I did the following:
$ svn co http://svn.apache.org/repos/asf/shindig/branches/2.0.x shindig-2.0.x
$ cd shindig-2.0.x
$ mvn compile
Best Regards,
Charl
--
Charl van Niekerk
ICT Service Centre
University of Twente
Re: Replacement for iGoogle gadgetsettings
Posted by Ryan Baxter <rb...@apache.org>.
On Mon, Jul 1, 2013 at 9:09 AM, Niekerk, C. van (Charl, ICTS)
<c....@utwente.nl> wrote:
> On Mon, Jul 01, 2013 at 07:34:29AM -0400, Ryan Baxter wrote:
>> I believe so. The first thing I would do is checkout that branch and
>> make sure it builds. I don't think we have that branch building on
>> builds.apache.org right now and I do not know what state it is in.
>
> I did a subversion checkout of that directory and ran mvn compile but it seems to be missing some tests:
>
> https://gist.github.com/anonymous/5900528
Which directory did you run mvn compile in? You should just be able
to run mvn in the top level folder.
>
>> Are you using Eclipse? If so the best thing to do is to import the
>> code style templates from the etc directory [1].
>
> I mostly use vim but that's no problem, I can use eclipse (even if it's just to format the code properly).
>
> Best Regards,
> Charl
>
> --
> Charl van Niekerk
> ICT Service Centre
> University of Twente
Re: Replacement for iGoogle gadgetsettings
Posted by "Niekerk, C. van (Charl, ICTS)" <c....@utwente.nl>.
On Mon, Jul 01, 2013 at 07:34:29AM -0400, Ryan Baxter wrote:
> I believe so. The first thing I would do is checkout that branch and
> make sure it builds. I don't think we have that branch building on
> builds.apache.org right now and I do not know what state it is in.
I did a subversion checkout of that directory and ran mvn compile but it seems to be missing some tests:
https://gist.github.com/anonymous/5900528
> Are you using Eclipse? If so the best thing to do is to import the
> code style templates from the etc directory [1].
I mostly use vim but that's no problem, I can use eclipse (even if it's just to format the code properly).
Best Regards,
Charl
--
Charl van Niekerk
ICT Service Centre
University of Twente
Re: Replacement for iGoogle gadgetsettings
Posted by Ryan Baxter <rb...@apache.org>.
On Mon, Jul 1, 2013 at 4:07 AM, Niekerk, C. van (Charl, ICTS)
<c....@utwente.nl> wrote:
> On Fri, Jun 28, 2013 at 03:32:51PM -0400, Ryan Baxter wrote:
>> Thanks Charl! Are you interested in contributing something more
>> formal, maybe in the way of a wiki article? Or better yet a patch to
>> the shindig 2.0 code base so that we could do a release with you code
>> in it?
>
> I would most certainly like to try my hand at integrating this directly into Shindig 2.0.
>
> That actually sounds like the most logical place for it, but I didn't want to "fork" the code base on my own.
>
> If you would consider including this in a release, that would be awesome, although it will need to be tested much more thoroughly first.
>
> Am I correct that this needs to be integrated into the following subversion branch?
>
> http://svn.apache.org/repos/asf/shindig/branches/2.0.x/
I believe so. The first thing I would do is checkout that branch and
make sure it builds. I don't think we have that branch building on
builds.apache.org right now and I do not know what state it is in.
>
> I might need to reformat the code as well to fit into your code conventions, but it seems like the link to the wiki is broken on:
>
> http://shindig.apache.org/code_conventions.html
Are you using Eclipse? If so the best thing to do is to import the
code style templates from the etc directory [1].
[1] http://svn.apache.org/repos/asf/shindig/branches/2.0.x/etc/eclipse/
>
> Best Regards,
> Charl
>
> --
> Charl van Niekerk
> ICT Service Centre
> University of Twente