You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "vishesh92 (via GitHub)" <gi...@apache.org> on 2023/07/28 09:28:26 UTC
[GitHub] [cloudstack] vishesh92 opened a new pull request, #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
vishesh92 opened a new pull request, #7784:
URL: https://github.com/apache/cloudstack/pull/7784
### Description
This PR generates coverage for Simulator based integration tests in github actions workflow and uploads the report to codecov.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1677119781
@vishesh92 Does this handle reports from multiple jobs and aggregate them somewhoe; could you look into (when you're free/have time): https://about.codecov.io/blog/uploading-code-coverage-in-a-separate-job-on-github-actions/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1680234085
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1677135525
@rohityadavcloud As per my understanding, codecov groups the coverage by [flags](https://docs.codecov.com/docs/flags).
See uploaded files for this PR here: https://app.codecov.io/gh/apache/cloudstack/commit/c944865bd84a1fab86755bc164123c64291adce1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1663315838
@vishesh92 good work and proposed PR, we may need a different way to track this perhaps? All tests in smoke should be ideally run against simulator/ci.yml, but other tests arne't included as they fail or amount of effort to stablise them would be huge.
smoke/test_gateway_on_shared_networks
smoke/test_guest_os
smoke/test_host_control_state
smoke/test_human_readable_logs
smoke/test_list_ids_parameter#
smoke/test_nonstrict_affinity_group
smoke/test_vm_autoscaling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1661657738
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#discussion_r1282664709
##########
.github/workflows/ci.yml:
##########
@@ -249,9 +256,16 @@ jobs:
mvn -q -Pdeveloper -pl developer -Ddeploydb
mvn -q -Pdeveloper -pl developer -Ddeploydb-simulator
+ - name: Generate jacoco-coverage.sh
+ run: |
+ echo "java -jar jacoco/lib/jacococli.jar report jacoco-it.exec \\" > jacoco-report.sh
+ find . | grep "target/classes" | sed 's/\/classes\//\/classes /g' | awk '{print "--classfiles", $1, "\\"}' | sort |uniq >> jacoco-report.sh
+ find . | grep "src/main/java" | sed 's/\/java\//\/java /g' | awk '{print "--sourcefiles", $1, "\\"}' | sort | uniq >> jacoco-report.sh
+ echo "--xml jacoco-coverage.xml" >> jacoco-report.sh
+
- name: Start CloudStack Management Server with Simulator
run: |
- export MAVEN_OPTS="-Xmx4096m -XX:MaxPermSize=800m -Djava.security.egd=file:/dev/urandom"
+ export MAVEN_OPTS="-Xmx4096m -XX:MaxPermSize=800m -Djava.security.egd=file:/dev/urandom -javaagent:jacoco/lib/jacocoagent.jar=address=*,port=36320,output=tcpserver"
Review Comment:
perhaps we can experiment this with our smoketests against actual environment and gather/publish the jacoco file separately cc @vishesh92 @borisstoyanov @vladimirpetrov @kiranchavala @DaanHoogland - so we've a unit test coverage stats and functional/marvin test coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1680236823
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1655353294
I found these tests that are not included in the `ci.yml`'s test matrix.
```
broken/maint
component/maint
component/test_acquire_specified_public_ip
component/test_advancedsg_networks
component/test_affinity_groups
component/test_base_image_updation
component/test_blocker_bugs
component/test_browse_templates
component/test_browse_templates2
component/test_browse_volumes
component/test_edgezone_supportedoperations
component/test_escalations_instances
component/test_haproxy
component/test_hypervisor_capabilities
component/test_implicit_planner
component/test_interop_xd_ccp
component/test_interpod_migration
component/test_ldap
component/test_migrate_vol_to_maintained_pool
component/test_multiple_nic_support
component/test_multiple_physical_network_creation
component/test_multiple_subnets_in_isolated_network
component/test_multiple_subnets_in_isolated_network_rvr
component/test_multiple_subnets_in_vpc
component/test_multiple_subnets_in_vpc_rvr
component/test_network_mtu
component/test_organization_states
component/test_portable_ip
component/test_ps_domain_limits
component/test_ps_limits
component/test_ps_project_limits
component/test_redundant_router_cleanups
component/test_redundant_router_services
component/test_redundant_router_upgrades
component/test_resource_count_running_vms
component/test_shared_networks
component/test_storage_motion
component/test_template_access_across_domains
component/test_volume_destroy_recover
component/test_vpc_network_internal_lbrules
component/test_vpc_vms_deployment
plugins/ldap
plugins/linstor
plugins/scaleio
plugins/test_quota
smoke/test_gateway_on_shared_networks
smoke/test_guest_os
smoke/test_host_control_state
smoke/test_human_readable_logs
smoke/test_list_ids_parameter#
smoke/test_nonstrict_affinity_group
smoke/test_vm_autoscaling
testpaths/testpath_custom_disk_offering
testpaths/testpath_netmask
testpaths/testpath_queryAsyncJobResult
testpaths/testpath_stopped_vm
testpaths/testpath_usage
testpaths/testpath_uuid_event
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vishesh92 closed pull request #7784: Generate coverage for Simulator based integration tests in github actions
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 closed pull request #7784: Generate coverage for Simulator based integration tests in github actions
URL: https://github.com/apache/cloudstack/pull/7784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1661657049
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1661761739
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#discussion_r1282929961
##########
.github/workflows/ci.yml:
##########
@@ -249,9 +256,16 @@ jobs:
mvn -q -Pdeveloper -pl developer -Ddeploydb
mvn -q -Pdeveloper -pl developer -Ddeploydb-simulator
+ - name: Generate jacoco-coverage.sh
+ run: |
+ echo "java -jar jacoco/lib/jacococli.jar report jacoco-it.exec \\" > jacoco-report.sh
+ find . | grep "target/classes" | sed 's/\/classes\//\/classes /g' | awk '{print "--classfiles", $1, "\\"}' | sort |uniq >> jacoco-report.sh
+ find . | grep "src/main/java" | sed 's/\/java\//\/java /g' | awk '{print "--sourcefiles", $1, "\\"}' | sort | uniq >> jacoco-report.sh
+ echo "--xml jacoco-coverage.xml" >> jacoco-report.sh
+
- name: Start CloudStack Management Server with Simulator
run: |
- export MAVEN_OPTS="-Xmx4096m -XX:MaxPermSize=800m -Djava.security.egd=file:/dev/urandom"
+ export MAVEN_OPTS="-Xmx4096m -XX:MaxPermSize=800m -Djava.security.egd=file:/dev/urandom -javaagent:jacoco/lib/jacocoagent.jar=address=*,port=36320,output=tcpserver"
Review Comment:
I would certainly like to have them separately, but nobody dies if we don't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1680327722
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
URL: https://github.com/apache/cloudstack/pull/7784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7784: Generate coverage for Simulator based integration tests in github actions
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1653521162
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7784](https://app.codecov.io/gh/apache/cloudstack/pull/7784?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (943ae16) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/8db8aa41637ad5405ad74ed3df69c7f44fdfa4ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8db8aa4) will **increase** coverage by `5.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #7784 +/- ##
============================================
+ Coverage 13.42% 18.44% +5.02%
- Complexity 9383 16453 +7070
============================================
Files 2747 4622 +1875
Lines 258827 310168 +51341
Branches 40318 43878 +3560
============================================
+ Hits 34748 57224 +22476
- Misses 219694 244779 +25085
- Partials 4385 8165 +3780
```
| Flag | Coverage Δ | |
|---|---|---|
| simulator-marvin-tests | `18.44% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 4025 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7784/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vishesh92 closed pull request #7784: Generate coverage for Simulator based integration tests in github actions
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 closed pull request #7784: Generate coverage for Simulator based integration tests in github actions
URL: https://github.com/apache/cloudstack/pull/7784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#discussion_r1282664709
##########
.github/workflows/ci.yml:
##########
@@ -249,9 +256,16 @@ jobs:
mvn -q -Pdeveloper -pl developer -Ddeploydb
mvn -q -Pdeveloper -pl developer -Ddeploydb-simulator
+ - name: Generate jacoco-coverage.sh
+ run: |
+ echo "java -jar jacoco/lib/jacococli.jar report jacoco-it.exec \\" > jacoco-report.sh
+ find . | grep "target/classes" | sed 's/\/classes\//\/classes /g' | awk '{print "--classfiles", $1, "\\"}' | sort |uniq >> jacoco-report.sh
+ find . | grep "src/main/java" | sed 's/\/java\//\/java /g' | awk '{print "--sourcefiles", $1, "\\"}' | sort | uniq >> jacoco-report.sh
+ echo "--xml jacoco-coverage.xml" >> jacoco-report.sh
+
- name: Start CloudStack Management Server with Simulator
run: |
- export MAVEN_OPTS="-Xmx4096m -XX:MaxPermSize=800m -Djava.security.egd=file:/dev/urandom"
+ export MAVEN_OPTS="-Xmx4096m -XX:MaxPermSize=800m -Djava.security.egd=file:/dev/urandom -javaagent:jacoco/lib/jacocoagent.jar=address=*,port=36320,output=tcpserver"
Review Comment:
perhaps we can experiment this with our smoketests against actual environment and gather/publish the jacoco file separately cc @vishesh92 @borisstoyanov @vladimirpetrov @kiranchavala @DaanHoogland - so we've a unit test coverage stats and functional/marvin test coverage stats (discuss - if you think, combined is also okay?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#issuecomment-1655368722
> I found these tests that are not included in the `ci.yml`'s test matrix.
I would not include any effort on those in this PR @vishesh92 . Best would be to create a tracking issue to decide which ones to delete/fix/add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
URL: https://github.com/apache/cloudstack/pull/7784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7784: Generate coverage for Simulator based integration tests & ui tests in github actions
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #7784:
URL: https://github.com/apache/cloudstack/pull/7784#discussion_r1282860623
##########
.github/workflows/ci.yml:
##########
@@ -249,9 +256,16 @@ jobs:
mvn -q -Pdeveloper -pl developer -Ddeploydb
mvn -q -Pdeveloper -pl developer -Ddeploydb-simulator
+ - name: Generate jacoco-coverage.sh
+ run: |
+ echo "java -jar jacoco/lib/jacococli.jar report jacoco-it.exec \\" > jacoco-report.sh
+ find . | grep "target/classes" | sed 's/\/classes\//\/classes /g' | awk '{print "--classfiles", $1, "\\"}' | sort |uniq >> jacoco-report.sh
+ find . | grep "src/main/java" | sed 's/\/java\//\/java /g' | awk '{print "--sourcefiles", $1, "\\"}' | sort | uniq >> jacoco-report.sh
+ echo "--xml jacoco-coverage.xml" >> jacoco-report.sh
+
- name: Start CloudStack Management Server with Simulator
run: |
- export MAVEN_OPTS="-Xmx4096m -XX:MaxPermSize=800m -Djava.security.egd=file:/dev/urandom"
+ export MAVEN_OPTS="-Xmx4096m -XX:MaxPermSize=800m -Djava.security.egd=file:/dev/urandom -javaagent:jacoco/lib/jacocoagent.jar=address=*,port=36320,output=tcpserver"
Review Comment:
@rohityadavcloud We can get the coverage from Blue Orangutan jobs. I can do that as well, but I don't have much idea about the setup as of now. So, I will need some time to look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org