You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dhalperi <gi...@git.apache.org> on 2016/06/16 16:48:48 UTC

[GitHub] incubator-beam pull request #476: [BEAM-350] DataflowPipelineJob: Retry mess...

GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/476

    [BEAM-350] DataflowPipelineJob: Retry messages, metrics, and status polls

    At some point in the past, we decided to use a rawDataflowClient that
    does not do retries when checking job status, because it was best-effort
    reporting to users. The purported goal was to not clutter the log with
    networking errors.
    
    However, since that time, we have:
    * Added the ability to suppress logs (emit only at DEBUG level or not at
      all) when retrying.
    * Increased reliability of the job checking status so that these errors
      are less frequent and more indicative of quota or other issues.
    * Started using the metrics in tests, where we do need to retry
      transient issues (BEAM-350).
    
    So let's drop the raw transport client and just use the one that
    retries.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam test-pipeline-runne

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #476
    
----
commit 127d7f48bb50e42f879ea4299f78889132ebc4b7
Author: Dan Halperin <dh...@google.com>
Date:   2016-06-16T15:57:18Z

    DataflowPipelineJob: Retry messages, metrics, and status polls
    
    At some point in the past, we decided to use a rawDataflowClient that
    does not do retries when checking job status, because it was best-effort
    reporting to users. The purported goal was to not clutter the log with
    networking errors.
    
    However, since that time, we have:
    * Added the ability to suppress logs (emit only at DEBUG level or not at
      all) when retrying.
    * Increased reliability of the job checking status so that these errors
      are less frequent and more indicative of quota or other issues.
    * Started using the metrics in tests, where we do need to retry
      transient issues (BEAM-350).
    
    So let's drop the raw transport client and just use the one that
    retries.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #476: [BEAM-350] DataflowPipelineJob: Retry mess...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/476


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---