You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Endre Zoltan Kovacs via Review Board <no...@reviews.apache.org> on 2017/08/28 07:00:37 UTC
Review Request 61931: fixing jdk download url in ranger dockerizing
script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61931/
-----------------------------------------------------------
Review request for ranger and Don Bosco Durai.
Bugs: RANGER-1739
https://issues.apache.org/jira/browse/RANGER-1739
Repository: ranger
Description
-------
RANGER-1739: dockerizing script cannot download jdk8
Diffs
-----
build_ranger_using_docker.sh fb722344
Diff: https://reviews.apache.org/r/61931/diff/1/
Testing
-------
without this script fails to download jdk8:
HTTP request sent, awaiting response... 404 Not Found
2017-08-17 14:17:29 ERROR 404: Not Found.
with this patch it downloads it nicely
Thanks,
Endre Zoltan Kovacs
Re: Review Request 61931: fixing jdk download url in ranger
dockerizing script
Posted by Endre Zoltan Kovacs via Review Board <no...@reviews.apache.org>.
> On Aug. 31, 2017, 10:28 p.m., Don Bosco Durai wrote:
> > Couldn't apply the patch
> > git apply -check 0001RANGER-1739-replaced-broken-Oracle-link-of-JDK8.patch
> > fatal: git diff header lacks filename information when removing 1 leading pathname component (line 14)
> >
> > Manually apply the changes worked.
> >
> > Please fix the patch file and commit.
> >
> > Thanks
>
> Endre Zoltan Kovacs wrote:
> hi @bosco
> You can check/apply this patch by
>
> git apply -p0 --check 0001-RANGER-1739-replaced-broken-Oracle-link-of-JDK8.patch
>
>
>
> The -p0 flag specifies how many leading slashes should be removed from the path specified in the patch. since the patch is patching a file in the root of the repo, and the patch itself has only the file name and no path, -p0 should be specified.
>
>
>
> (-p<n>
> Remove <n> leading slashes from traditional diff paths. The default is 1)
>
> The patch itself was created by following the guide at https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244
> So not sure why this was necessary...
> Thanks for the review.
> Cheers,
> Endre
i think i get it now:
I did follow the above link in creating the patch.
===BUT===
i had a git global setting causing all my patches to be incompatible with the ranger repo...
so i proceeded with setting prefixes to false:
git config diff.noprefix false
and creating the patch again. patch created using this setting, applied cleanly locally.
I suggest adding this config to the contribution guide.
- Endre Zoltan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61931/#review184321
-----------------------------------------------------------
On Sept. 4, 2017, 8:31 a.m., Endre Zoltan Kovacs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61931/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 8:31 a.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Bugs: RANGER-1739
> https://issues.apache.org/jira/browse/RANGER-1739
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1739: dockerizing script cannot download jdk8
>
>
> Diffs
> -----
>
> build_ranger_using_docker.sh fb7223445
>
>
> Diff: https://reviews.apache.org/r/61931/diff/2/
>
>
> Testing
> -------
>
> without this script fails to download jdk8:
>
> HTTP request sent, awaiting response... 404 Not Found
> 2017-08-17 14:17:29 ERROR 404: Not Found.
>
> with this patch it downloads it nicely
>
>
> Thanks,
>
> Endre Zoltan Kovacs
>
>
Re: Review Request 61931: fixing jdk download url in ranger
dockerizing script
Posted by Endre Zoltan Kovacs via Review Board <no...@reviews.apache.org>.
> On Aug. 31, 2017, 10:28 p.m., Don Bosco Durai wrote:
> > Couldn't apply the patch
> > git apply -check 0001RANGER-1739-replaced-broken-Oracle-link-of-JDK8.patch
> > fatal: git diff header lacks filename information when removing 1 leading pathname component (line 14)
> >
> > Manually apply the changes worked.
> >
> > Please fix the patch file and commit.
> >
> > Thanks
hi @bosco
You can check/apply this patch by
git apply -p0 --check 0001-RANGER-1739-replaced-broken-Oracle-link-of-JDK8.patch
The -p0 flag specifies how many leading slashes should be removed from the path specified in the patch. since the patch is patching a file in the root of the repo, and the patch itself has only the file name and no path, -p0 should be specified.
(-p<n>
Remove <n> leading slashes from traditional diff paths. The default is 1)
The patch itself was created by following the guide at https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244
So not sure why this was necessary...
Thanks for the review.
Cheers,
Endre
- Endre Zoltan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61931/#review184321
-----------------------------------------------------------
On Aug. 28, 2017, 7 a.m., Endre Zoltan Kovacs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61931/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 7 a.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Bugs: RANGER-1739
> https://issues.apache.org/jira/browse/RANGER-1739
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1739: dockerizing script cannot download jdk8
>
>
> Diffs
> -----
>
> build_ranger_using_docker.sh fb722344
>
>
> Diff: https://reviews.apache.org/r/61931/diff/1/
>
>
> Testing
> -------
>
> without this script fails to download jdk8:
>
> HTTP request sent, awaiting response... 404 Not Found
> 2017-08-17 14:17:29 ERROR 404: Not Found.
>
> with this patch it downloads it nicely
>
>
> Thanks,
>
> Endre Zoltan Kovacs
>
>
Re: Review Request 61931: fixing jdk download url in ranger
dockerizing script
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61931/#review184321
-----------------------------------------------------------
Ship it!
Couldn't apply the patch
git apply -check 0001RANGER-1739-replaced-broken-Oracle-link-of-JDK8.patch
fatal: git diff header lacks filename information when removing 1 leading pathname component (line 14)
Manually apply the changes worked.
Please fix the patch file and commit.
Thanks
- Don Bosco Durai
On Aug. 28, 2017, 7 a.m., Endre Zoltan Kovacs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61931/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 7 a.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Bugs: RANGER-1739
> https://issues.apache.org/jira/browse/RANGER-1739
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1739: dockerizing script cannot download jdk8
>
>
> Diffs
> -----
>
> build_ranger_using_docker.sh fb722344
>
>
> Diff: https://reviews.apache.org/r/61931/diff/1/
>
>
> Testing
> -------
>
> without this script fails to download jdk8:
>
> HTTP request sent, awaiting response... 404 Not Found
> 2017-08-17 14:17:29 ERROR 404: Not Found.
>
> with this patch it downloads it nicely
>
>
> Thanks,
>
> Endre Zoltan Kovacs
>
>
Re: Review Request 61931: fixing jdk download url in ranger
dockerizing script
Posted by Endre Zoltan Kovacs via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61931/
-----------------------------------------------------------
(Updated Sept. 4, 2017, 8:31 a.m.)
Review request for ranger and Don Bosco Durai.
Changes
-------
re-cut patch so now it applies cleanly
Bugs: RANGER-1739
https://issues.apache.org/jira/browse/RANGER-1739
Repository: ranger
Description
-------
RANGER-1739: dockerizing script cannot download jdk8
Diffs (updated)
-----
build_ranger_using_docker.sh fb7223445
Diff: https://reviews.apache.org/r/61931/diff/2/
Changes: https://reviews.apache.org/r/61931/diff/1-2/
Testing
-------
without this script fails to download jdk8:
HTTP request sent, awaiting response... 404 Not Found
2017-08-17 14:17:29 ERROR 404: Not Found.
with this patch it downloads it nicely
Thanks,
Endre Zoltan Kovacs