You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/06 17:17:36 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2471: Minor: Use ExprVisitor to find columns referenced by expr

alamb commented on code in PR #2471:
URL: https://github.com/apache/arrow-datafusion/pull/2471#discussion_r867025445


##########
datafusion/expr/src/expr.rs:
##########
@@ -251,77 +251,6 @@ pub enum Expr {
     QualifiedWildcard { qualifier: String },
 }
 
-/// Recursively find all columns referenced by an expression
-pub fn find_columns_referenced_by_expr(e: &Expr) -> Vec<Column> {

Review Comment:
   it is less code, but it also avoids potential issues in missing a sub expr



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org