[jira] [Comment Edited] (VFS-291) ZIP archives are not properly closed after unzipping and cannot be deleted until the JVM exists

["Gary Gregory (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VFS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172253#comment-16172253 ] 

Gary Gregory edited comment on VFS-291 at 9/19/17 8:01 PM:
-----------------------------------------------------------

Add refinement:
{noformat}
commit -m "[VFS-291] ZIP archives are not properly closed after unzipping and cannot be deleted until the JVM exists. Do not close underlying ZipFile too aggressively; only do so if all open streams are not in use!" -N C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileObject.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileObject.java
    Transmitting file data ...
    Unknown action received: commit finalizing
    Committed revision 1808941.
{noformat}



was (Author: garydgregory):
Add refinement:
{noformat}
commit -m "[VFS-291] ZIP archives are not properly closed after unzipping and cannot be deleted until the JVM exists. Do not close underlying ZipFile too aggressively; only do so if all open streams are not in use!" -N C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileObjectTestCase.java
    Sending        C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileObjectTestCase.java
    Transmitting file data ...
    Unknown action received: commit finalizing
    Committed revision 1808939.
{noformat}


> ZIP archives are not properly closed after unzipping and cannot be deleted until the JVM exists
> -----------------------------------------------------------------------------------------------
>
>                 Key: VFS-291
>                 URL: https://issues.apache.org/jira/browse/VFS-291
>             Project: Commons VFS
>          Issue Type: Bug
>         Environment: Windows
>            Reporter: Roman
>            Priority: Critical
>              Labels: patch
>             Fix For: 2.2
>
>         Attachments: AbstractFileObject.java.2.patch, AbstractFileObject.java.patch, FileLockUnitTest.diff, vfs-291.diff, ZipCloseBug.zip, ZipFileObject.java, ZipFileObject.java.patch
>
>
> Open a zip file with the ZipFileObject
> get an inputstream on its content
> try to delete it... 
> it fails.
> I have attached a possible solution to this bug.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)