You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by David Blevins <da...@visi.com> on 2010/06/02 09:13:45 UTC
Re: [jira] Updated: (OPENEJB-1287) java.lang.NullPointerException: null: null at org.apache.openejb.assembler.classic.Assembler.createApplication
On Jun 1, 2010, at 10:29 PM, Shawn Jiang wrote:
> Hi dev,
>
> Can anyone help look at the patch ? It's a blocker for geronimo 2.2.1
> release. Thanks in advance !
>
> ---------- Forwarded message ----------
> From: Shawn Jiang (JIRA) <ji...@apache.org>
> Date: Tue, Jun 1, 2010 at 5:28 PM
> Subject: [jira] Updated: (OPENEJB-1287) java.lang.NullPointerException:
> null: null at
> org.apache.openejb.assembler.classic.Assembler.createApplication
> To: genspring@gmail.com
>
>
>
> [
> https://issues.apache.org/jira/browse/OPENEJB-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Shawn Jiang updated OPENEJB-1287:
> ---------------------------------
>
> Attachment: OPENEJB-1287.patch
>
> I can see following code
>
> if (accessTimeout.getUnit() == null)
> accessTimeout.setUnit(TimeUnit.MILLISECONDS);
>
> in StatelessInstanceManager. Why not to make null unit fall back to
> MILLISECONDS by default in Duration ?
Hi Shawn!
The hard part about setting the default in the Duration class itself is that some usages of it default to different time units. The StatefulTimeout defaults to MINUTES for example.
Looks like we missed setting the default for IdleTimeout, MaxAge and PollInterval. I went ahead and added that for all of them and checked it in.
Thanks for the reminder!
-David
3.1.x snapshots (was: OPENEJB-1287)
Posted by David Blevins <da...@visi.com>.
On Jun 6, 2010, at 11:05 PM, Shawn Jiang wrote:
> Could anyone help push a new snapshot to the repo ? Geronimo 2.2 branch
> can't start without the new open ejb snapshot including this jira.
>
> On Wed, Jun 2, 2010 at 11:21 PM, Shawn Jiang <ge...@gmail.com> wrote:
>
>> Will you push a new snapshot to the repo ? I want to verify if the fix
>> resolve the problem in geronimo 221 side.
Hi Shawn,
I'm not sure what might be happening, but the snapshots are current.
openejb-core-3.1.3-20100528.182151-23.jar Fri May 28 18:30:11 GMT+00:00 2010 1624859
openejb-core-3.1.3-20100529.000932-24.jar Sat May 29 00:27:28 GMT+00:00 2010 1624859
openejb-core-3.1.3-20100604.233959-25.jar Fri Jun 04 23:51:40 GMT+00:00 2010 1625626
openejb-core-3.1.3-20100605.000050-26.jar Sat Jun 05 00:16:51 GMT+00:00 2010 1625500
The latest snapshot is about an hour after the last 3.1.x branch commit.
Author: dblevins
Date: Fri Jun 4 23:15:45 2010
New Revision: 951613
URL: http://svn.apache.org/viewvc?rev=951613&view=rev
Log:
Reverting java: prefix change previously merged from trunk
Any ideas on how we can help?
-David
Re: [jira] Updated: (OPENEJB-1287) java.lang.NullPointerException:
null: null at org.apache.openejb.assembler.classic.Assembler.createApplication
Posted by Shawn Jiang <ge...@gmail.com>.
Could anyone help push a new snapshot to the repo ? Geronimo 2.2 branch
can't start without the new open ejb snapshot including this jira.
Thanks in advance !
On Wed, Jun 2, 2010 at 11:21 PM, Shawn Jiang <ge...@gmail.com> wrote:
> I understand, to add default unit for these attributes should also work
> for me.
>
> Will you push a new snapshot to the repo ? I want to verify if the fix
> resolve the problem in geronimo 221 side.
>
>
> On Wed, Jun 2, 2010 at 3:13 PM, David Blevins <da...@visi.com>wrote:
>
>>
>> On Jun 1, 2010, at 10:29 PM, Shawn Jiang wrote:
>>
>> > Hi dev,
>> >
>> > Can anyone help look at the patch ? It's a blocker for geronimo 2.2.1
>> > release. Thanks in advance !
>> >
>> > ---------- Forwarded message ----------
>> > From: Shawn Jiang (JIRA) <ji...@apache.org>
>> > Date: Tue, Jun 1, 2010 at 5:28 PM
>> > Subject: [jira] Updated: (OPENEJB-1287) java.lang.NullPointerException:
>> > null: null at
>> > org.apache.openejb.assembler.classic.Assembler.createApplication
>> > To: genspring@gmail.com
>> >
>> >
>> >
>> > [
>> >
>> https://issues.apache.org/jira/browse/OPENEJB-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>> >
>> > Shawn Jiang updated OPENEJB-1287:
>> > ---------------------------------
>> >
>> > Attachment: OPENEJB-1287.patch
>> >
>> > I can see following code
>> >
>> > if (accessTimeout.getUnit() == null)
>> > accessTimeout.setUnit(TimeUnit.MILLISECONDS);
>> >
>> > in StatelessInstanceManager. Why not to make null unit fall back to
>> > MILLISECONDS by default in Duration ?
>>
>> Hi Shawn!
>>
>> The hard part about setting the default in the Duration class itself is
>> that some usages of it default to different time units. The StatefulTimeout
>> defaults to MINUTES for example.
>>
>> Looks like we missed setting the default for IdleTimeout, MaxAge and
>> PollInterval. I went ahead and added that for all of them and checked it
>> in.
>>
>> Thanks for the reminder!
>>
>> -David
>>
>>
>
>
> --
> Shawn
>
--
Shawn
Re: [jira] Updated: (OPENEJB-1287) java.lang.NullPointerException:
null: null at org.apache.openejb.assembler.classic.Assembler.createApplication
Posted by Shawn Jiang <ge...@gmail.com>.
I understand, to add default unit for these attributes should also work for
me.
Will you push a new snapshot to the repo ? I want to verify if the fix
resolve the problem in geronimo 221 side.
On Wed, Jun 2, 2010 at 3:13 PM, David Blevins <da...@visi.com>wrote:
>
> On Jun 1, 2010, at 10:29 PM, Shawn Jiang wrote:
>
> > Hi dev,
> >
> > Can anyone help look at the patch ? It's a blocker for geronimo 2.2.1
> > release. Thanks in advance !
> >
> > ---------- Forwarded message ----------
> > From: Shawn Jiang (JIRA) <ji...@apache.org>
> > Date: Tue, Jun 1, 2010 at 5:28 PM
> > Subject: [jira] Updated: (OPENEJB-1287) java.lang.NullPointerException:
> > null: null at
> > org.apache.openejb.assembler.classic.Assembler.createApplication
> > To: genspring@gmail.com
> >
> >
> >
> > [
> >
> https://issues.apache.org/jira/browse/OPENEJB-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> >
> > Shawn Jiang updated OPENEJB-1287:
> > ---------------------------------
> >
> > Attachment: OPENEJB-1287.patch
> >
> > I can see following code
> >
> > if (accessTimeout.getUnit() == null)
> > accessTimeout.setUnit(TimeUnit.MILLISECONDS);
> >
> > in StatelessInstanceManager. Why not to make null unit fall back to
> > MILLISECONDS by default in Duration ?
>
> Hi Shawn!
>
> The hard part about setting the default in the Duration class itself is
> that some usages of it default to different time units. The StatefulTimeout
> defaults to MINUTES for example.
>
> Looks like we missed setting the default for IdleTimeout, MaxAge and
> PollInterval. I went ahead and added that for all of them and checked it
> in.
>
> Thanks for the reminder!
>
> -David
>
>
--
Shawn